fix(backfill): Monolithic backfill stores PR-inclusive count as openIssuesCount - #177
Closed
glorysr1209-png wants to merge 5 commits into
Closed
fix(backfill): Monolithic backfill stores PR-inclusive count as openIssuesCount#177glorysr1209-png wants to merge 5 commits into
glorysr1209-png wants to merge 5 commits into
Conversation
JSONbored
requested changes
Jun 1, 2026
JSONbored
left a comment
Owner
There was a problem hiding this comment.
@glorysr1209-png the direction makes sense, but this needs tests and a full CI run before I can take it.
A few notes:
- Filtering
/issuesresults before storingopenIssuesCountis the right idea. GitHub’s REST issues endpoint includes pull requests, so using the raw fetched count can overstate issue totals. - This only changes the count assignment; it does not add a regression test proving PR-shaped issue rows are excluded from
repo_sync_state, snapshots, and the returned backfill result. - I also do not see the normal CI
validatecheck on this PR yet, so it is not mergeable even if the patch is small.
Required changes:
- Add a focused regression test where the REST issues page contains both real issues and PR-shaped entries.
- Assert
openIssuesCountstores only real issues whileopenPullRequestsCountstill comes from the PR endpoint. - Get the normal
validateworkflow green.
Validation expected:
npm run typechecknpm run test:coverage
This was referenced Jun 2, 2026
JSONbored
self-requested a review
June 3, 2026 22:17
JSONbored
requested changes
Jun 3, 2026
JSONbored
left a comment
Owner
There was a problem hiding this comment.
@glorysr1209-png this is still blocked by CI.
A few notes:
- The open issue count bug is in the right backfill area.
- Current validate fails
test/unit/backfill.test.ts: expectedopenIssues: 201, received1. - The PR body also needs current validation/safety evidence.
Required changes:
- Fix the failing backfill assertion without weakening the intended behavior.
- Update the PR body to the current template.
Validation expected:
- Focused
test/unit/backfill.test.ts - Full validate pipeline
Owner
|
This is stale, closing - please resubmit with all issues addressed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #176.
Use filtered issue count (exclude PR-shaped
/issuesrows) foropenIssuesCountand backfill return payload.Changes
src/github/backfill.ts:openIssueCount = issues.lengthafter PR filter.Test plan
npm test -- backfill.test.ts/issuespage;openIssuesmatches true open issues only.