fix(rees): return degraded history before caller timeout - #1805
Conversation
|
Tip 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 ✅ Gittensory review result - approve/merge recommendedReview updated: 2026-06-30 02:49:20 UTC
✅ Suggested Action - Approve/Merge
Review summary Nits — 5 non-blocking
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1805 +/- ##
=======================================
Coverage 95.61% 95.61%
=======================================
Files 214 214
Lines 23233 23249 +16
Branches 8393 8398 +5
=======================================
+ Hits 22214 22230 +16
Misses 422 422
Partials 597 597
🚀 New features to boost your workflow:
|
Summary
historyanalyzer budget-aware with bounded fanout, per-GitHub-subcall aborts, lookup caps, and partial status instead of a generic timeout.Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.This is scoped to the production REES timeout path surfaced by Sentry issue
GITTENSORY-T; no separate GitHub issue is linked.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragelocally;codecov/patchrequires >=97% coverage of the lines AND branches you changed (aim for 98%+ on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.npm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderateAlso ran focused checks:
npm --prefix review-enrichment testnpx vitest run test/unit/enrichment-wire.test.tsIf any required check was skipped, explain why:
npm run test:cicompleted successfully and covers the listed local gate commands except audit; audit was run separately.Safety
UI Evidencesection below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.No auth, cookie, CORS, GitHub App, Cloudflare, session, or visible UI behavior changed. REES Sentry context tests cover sanitizer boundaries for sensitive payload fields.
UI Evidence
Not applicable. This changes backend REES behavior, the engine REES caller, tests, and non-visual REES deployment notes only.
Notes
Railway deployment note: deploy the updated
review-enrichmentservice before relying on the new default behavior. After deployment, the engine defaultREES_TIMEOUT_MS=8000sends abudget.timeoutMsof7000, giving REES one second of headroom to return partial analyzer status. Until the Railway service is updated, temporarily raise the engine-sideREES_TIMEOUT_MSabove the old REES analyzer budget or setREES_ANALYZERSto a bounded list that excludeshistory.Sentry setup note: keep
SENTRY_DSN, release/source-map settings, and Railway-provided release metadata configured through Railway environment variables. Do not print or commit any secret values.