Skip to content

docs: align CONTRIBUTING patch coverage with codecov.yml (99%) - #2372

Closed
bohdansolovie wants to merge 2 commits into
JSONbored:mainfrom
bohdansolovie:docs/contributing-codecov-99-percent
Closed

docs: align CONTRIBUTING patch coverage with codecov.yml (99%)#2372
bohdansolovie wants to merge 2 commits into
JSONbored:mainfrom
bohdansolovie:docs/contributing-codecov-99-percent

Conversation

@bohdansolovie

@bohdansolovie bohdansolovie commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Summary

Test plan

  • Doc-only change

@bohdansolovie
bohdansolovie requested a review from JSONbored as a code owner July 1, 2026 13:37
@dosubot dosubot Bot added the size:XS label Jul 1, 2026
@bohdansolovie
bohdansolovie force-pushed the docs/contributing-codecov-99-percent branch from 8337984 to b0d322a Compare July 1, 2026 13:38
The hard gate was raised in JSONbored#1975; contributor docs still said 97%.

Co-authored-by: Cursor <cursoragent@cursor.com>
@bohdansolovie
bohdansolovie force-pushed the docs/contributing-codecov-99-percent branch from b0d322a to d13c625 Compare July 1, 2026 13:38
@loopover-orb

loopover-orb Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

Review updated: 2026-07-02 04:11:44 UTC

2 files · 1 AI reviewer · no blockers · readiness 73/100 · CI green · clean

⏸️ Suggested Action - Manual Review

Review summary
The diff correctly updates the two CONTRIBUTING.md coverage references from 97% to 99% and adds a policy test tying the documentation to the current codecov.yml target. The added test is scoped to the changed documentation and the existing Codecov policy shape, so the visible change is safe enough to proceed. The main maintainability detail is that the new test still hard-codes the same target string it reads from config instead of deriving the expected documentation text from that value.

Nits — 3 non-blocking
  • nit: test/unit/codecov-policy.test.ts:37 hard-codes "99%" after reading codecov.yml, so a future target change would still require updating both the assertion and the documentation regexes instead of testing alignment generically.
  • test/unit/codecov-policy.test.ts:37 could derive the escaped target from `patchTarget` and assert CONTRIBUTING.md contains that value, while keeping the existing explicit policy assertion in the earlier `keeps patch coverage strict and PR-scoped` test.
  • Readiness score is below the configured threshold — Use the readiness panel as advisory maintainer context; the score does not block this PR.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ✅ No-issue rationale PR body explains why no issue is linked.
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (size label size:XS; no linked issue context).
Validation posture ❌ 5/25 Preflight is holding this PR: the review lane is unavailable, so it is not ready for automated review.
Contributor workload ✅ 10/10 Author activity: 140 registered-repo PR(s), 68 merged, 11 issue(s).
Contributor context ✅ Confirmed Gittensor contributor bohdansolovie; Gittensor profile; 140 PR(s), 11 issue(s).
Gate result ✅ Passing No configured blocker found.
Review context
  • Author: bohdansolovie
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: not available
  • Official Gittensor activity: 140 PR(s), 11 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Await review-lane availability.
  • Triage stale or unlinked PRs.
  • Refresh registry data or choose a registered active repo.
  • Link the issue being solved, or explicitly explain why this is a no-issue PR.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@loopover-orb loopover-orb Bot added gittensor gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. labels Jul 1, 2026
Update stale 97% contributor guidance and lock it with a codecov-policy
test so docs stay aligned with the 99% patch gate from JSONbored#1975.

Co-authored-by: Cursor <cursoragent@cursor.com>
@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.71%. Comparing base (17d70b2) to head (549be57).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2372   +/-   ##
=======================================
  Coverage   95.71%   95.71%           
=======================================
  Files         222      222           
  Lines       24661    24661           
  Branches     8949     8949           
=======================================
  Hits        23605    23605           
  Misses        433      433           
  Partials      623      623           
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JSONbored JSONbored left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix this, then resubmit:

The main maintainability detail is that the new test still hard-codes the same target string it reads from config instead of deriving the expected documentation text from that value.

@JSONbored JSONbored closed this Jul 2, 2026
@github-project-automation github-project-automation Bot moved this from Todo to Done in gittensory - v1 roadmap Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants