Skip to content

fix(signals): classify PHP source files as code #2845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
loopover-orb merged 1 commit into from
Jul 3, 2026
Merged

fix(signals): classify PHP source files as code #2845

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/signals/engine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5515,11 +5515,11 @@ function sanitizeOutcomeDimensionKey(key: string): string {
}

function isCodeFile(file: string): boolean {
// Mirrors isCodeFile in local-branch.ts — kept in sync (cs/swift/groovy added
// so C#/Swift/Groovy source counts as code, matching the test conventions
// Mirrors isCodeFile in local-branch.ts — kept in sync (cs/swift/groovy/php added
// so C#/Swift/Groovy/PHP source counts as code, matching the test conventions
// isTestPath already recognizes).
return (
/\.(ts|tsx|mts|cts|js|jsx|mjs|cjs|py|rb|rs|kt|scala|java|go|sql|cs|swift|groovy)$/i.test(file) &&
/\.(ts|tsx|mts|cts|js|jsx|mjs|cjs|py|rb|rs|kt|scala|java|go|sql|cs|swift|groovy|php)$/i.test(file) &&
!isTestFile(file)
);
}
Expand Down
6 changes: 3 additions & 3 deletions src/signals/local-branch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1267,12 +1267,12 @@ export function isTestFile(file: string): boolean {
}

export function isCodeFile(file: string): boolean {
// cs/swift/groovy round out the JVM/.NET/Swift set: isTestPath already
// cs/swift/groovy/php round out the JVM/.NET/Swift/PHP set: isTestPath already
// recognizes their `SomethingTest(s)`/`Spec` test files, so their source must
// count as code too — otherwise a C#/Swift/Groovy source file is neither test
// count as code too — otherwise a C#/Swift/Groovy/PHP source file is neither test
// nor code in the local scorer.
return (
/\.(ts|tsx|mts|cts|js|jsx|mjs|cjs|py|rb|rs|kt|scala|java|go|sql|cs|swift|groovy)$/i.test(file) &&
/\.(ts|tsx|mts|cts|js|jsx|mjs|cjs|py|rb|rs|kt|scala|java|go|sql|cs|swift|groovy|php)$/i.test(file) &&
!isTestFile(file)
);
}
Expand Down
6 changes: 6 additions & 0 deletions test/unit/local-branch-file-classifiers.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,10 @@ describe("isCodeFile", () => {
"Api/Controllers/UserController.cs",
"Sources/App/Router.swift",
"src/main/groovy/Pipeline.groovy",
// PHP source — isTestPath already recognizes PHPUnit/PHPSpec `SomethingTest`/`Spec`
// files, so PHP source must count as code too (else it is neither test nor code).
"app/Http/Controllers/UserController.php",
"src/Service/PaymentGateway.php",
]) {
expect(isCodeFile(path)).toBe(true);
}
Expand All @@ -141,6 +145,8 @@ describe("isCodeFile", () => {
// C#/Swift test files carry a code extension but are tests, not code.
"Services/AccountTests.cs",
"AppTests/LoginTests.swift",
// PHP class-suffix test file (PHPUnit) — code extension, but a test, not code.
"app/Service/PaymentTest.php",
]) {
expect(isCodeFile(path)).toBe(false);
}
Expand Down
Loading