fix(signals): diff all registry config fields in change reports - #307
Merged
JSONbored merged 3 commits intoJun 3, 2026
Merged
Conversation
JSONbored
requested changes
Jun 2, 2026
JSONbored
left a comment
Owner
There was a problem hiding this comment.
@philluiz2323 the change looks useful and CI is green, but the PR title needs to match the repo convention.
Required change:
- Retitle this to something like
fix(signals): diff all registry config fields in change reports.
Validation expected:
- Keep npm run test:ci green.
Contributor
Author
done |
JSONbored
approved these changes
Jun 3, 2026
JSONbored
left a comment
Owner
There was a problem hiding this comment.
@philluiz2323 the change may be small, but the PR still needs to meet the repo gate.
A few notes:
- Registry config diff coverage is a reasonable fix.
- The current title has a trailing period. (I fixed this)
- The body is missing current template evidence. (it's fine for now).
Required changes:
- None for now.
Validation expected:
- Focused signal tests.
- Full CI green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #280.
Problem
buildRegistryChangeReportdiffed only 5 of the 8 comparableRegistryRepoConfigfields, omittingfixedBaseScore,defaultLabelMultiplier, andeligibilityMode. A repo whose only change is one of those fields produced an emptychangesarray and was dropped fromchangedRepos, so the report said0 changedeven though scoring materially changed (fixedBaseScoreoverrides the entire base score, preview.ts:287). The authoritative drift comparator (REGISTRY_DRIFT_COMPARABLE_FIELDSin upstream/ruleset.ts:606-615) already compares all 8 fields; the live report had drifted from it.This is public-facing:
GET /v1/registry/changes(routes.ts) and theregistry-changesMCP tool.Fix
Replace the 5 hardcoded comparison branches with a single data-driven field-descriptor table (
REGISTRY_CHANGE_FIELDS) covering all 8 comparable fields, rendered to stable strings and diffed in one loop (registryConfigChanges). This addsfixed_base_score,default_label_multiplier, andeligibility_modeto the report and keeps the live report and the upstream drift comparator from diverging again as config fields are added. Existing change-line output for the original fields is preserved.Tests
Added a fail-on-revert test: a snapshot pair differing only in
fixedBaseScore(2 -> 50) must yield achangedReposentry withfixed_base_score 2 -> 50and a1 changedsummary; andeligibility_mode/default_label_multiplierchanges are likewise surfaced. The existing test only exercised the 5 originally-compared fields, ratifying the omission.vitest runsignals-v2 + signals + registry 61/61; integration api 21/21;tsc --noEmitclean.