Skip to content

feat(enrichment): treat HEIC/HEIF images as binary assets - #3089

Merged
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
bohdansolovie:feat/asset-weight-heic-heif
Jul 4, 2026
Merged

feat(enrichment): treat HEIC/HEIF images as binary assets#3089
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
bohdansolovie:feat/asset-weight-heic-heif

Conversation

@bohdansolovie

Copy link
Copy Markdown
Contributor

Summary

The assetWeight analyzer flags heavy binary blobs whose sizes are not in the textual diff. Its extension set already included modern image formats (webp, avif) but missed Apple's HEIC/HEIF photo formats, so a PR that commits large HEIC photos was not weighed.

Scope

Adds heic and heif to BINARY_EXTS. Matching stays case-insensitive via the existing toLowerCase() path. Text formats (svg/json/…) remain excluded.

Test plan

  • Extends review-enrichment/test/asset-weight.test.ts with .heic / .heif / .HEIC positives on the exported isBinaryAsset path.
  • node --test test/asset-weight.test.ts — 3 passed.

No linked issue

Self-contained detection-coverage improvement; no tracking issue. Touches only asset-weight.ts and its test.

Made with Cursor

The asset-weight analyzer flags heavy binary blobs whose sizes are not in the
textual diff, but its extension set included webp/avif and missed Apple's
HEIC/HEIF photo formats. Add both so a PR that commits large HEIC photos is
weighed like other binary images.

Co-authored-by: Cursor <cursoragent@cursor.com>
@bohdansolovie
bohdansolovie requested a review from JSONbored as a code owner July 4, 2026 13:37
@superagent-security superagent-security Bot added the contributor:flagged Contributor flagged for review by trust analysis. label Jul 4, 2026
@superagent-security

Copy link
Copy Markdown
Contributor

🚨 Contributor flagged. Click here for more info: Superagent Dashboard

@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@loopover-orb loopover-orb Bot added the gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. label Jul 4, 2026
@loopover-orb

loopover-orb Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

Review updated: 2026-07-04 13:37:19 UTC

2 files · 1 AI reviewer · no blockers · readiness 73/100 · CI green · clean

⏸️ Suggested Action - Manual Review

Review summary
This change correctly extends the asset-weight binary extension allowlist to include HEIC/HEIF, and the production path remains the existing case-insensitive `isBinaryAsset()` extension check. The added tests exercise the exported helper on `.heic`, `.heif`, and uppercase `.HEIC`, so the claimed behavior is covered without fabricating an unreachable path. The rest of the source diff is formatting-only and does not change analyzer behavior.

Nits — 4 non-blocking
  • nit: `review-enrichment/src/analyzers/asset-weight.ts:136` and the later wrapped calls are unrelated formatting churn; keeping this PR to the two extension lines would make the detection change easier to audit.
  • `review-enrichment/test/asset-weight.test.ts:12` could fold the new HEIC/HEIF examples into the existing binary-positive loop so future extension coverage stays in one table.
  • `review-enrichment/src/analyzers/asset-weight.ts:136` should be reverted to the preexisting formatting unless the repo formatter requires this wrapping, because it is unrelated to HEIC/HEIF support.
  • Readiness score is below the configured threshold — Use the readiness panel as advisory maintainer context; the score does not block this PR.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ⚠️ Missing No linked issue or no-issue rationale found.
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (no linked issue context).
Validation posture ❌ 5/25 Preflight is holding this PR: the review lane is unavailable, so it is not ready for automated review.
Contributor workload ✅ 10/10 Author activity: 127 registered-repo PR(s), 58 merged, 10 issue(s).
Contributor context ✅ Confirmed Gittensor contributor bohdansolovie; Gittensor profile; 127 PR(s), 10 issue(s).
Gate result ✅ Passing No configured blocker found.
Review context
  • Author: bohdansolovie
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: Python, C++, JavaScript
  • Official Gittensor activity: 127 PR(s), 10 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Explain no-issue PR.
  • Await review-lane availability.
  • Refresh registry data or choose a registered active repo.
  • Link the issue being solved, or explicitly explain why this is a no-issue PR.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gittensory approves — the gate is satisfied and CI is green.

@loopover-orb
loopover-orb Bot merged commit bd4e009 into JSONbored:main Jul 4, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor:flagged Contributor flagged for review by trust analysis. gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant