feat(enrichment): treat HEIC/HEIF images as binary assets - #3089
Conversation
The asset-weight analyzer flags heavy binary blobs whose sizes are not in the textual diff, but its extension set included webp/avif and missed Apple's HEIC/HEIF photo formats. Add both so a PR that commits large HEIC photos is weighed like other binary images. Co-authored-by: Cursor <cursoragent@cursor.com>
|
🚨 Contributor flagged. Click here for more info: Superagent Dashboard |
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-04 13:37:19 UTC
⏸️ Suggested Action - Manual Review Review summary Nits — 4 non-blocking
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Summary
The
assetWeightanalyzer flags heavy binary blobs whose sizes are not in the textual diff. Its extension set already included modern image formats (webp,avif) but missed Apple's HEIC/HEIF photo formats, so a PR that commits large HEIC photos was not weighed.Scope
Adds
heicandheiftoBINARY_EXTS. Matching stays case-insensitive via the existingtoLowerCase()path. Text formats (svg/json/…) remain excluded.Test plan
review-enrichment/test/asset-weight.test.tswith.heic/.heif/.HEICpositives on the exportedisBinaryAssetpath.node --test test/asset-weight.test.ts— 3 passed.No linked issue
Self-contained detection-coverage improvement; no tracking issue. Touches only
asset-weight.tsand its test.Made with Cursor