Skip to content

fix(selfhost): recognize review_audit in the exporter's no-source-tables guard #3546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSONbored merged 1 commit into from
Jul 5, 2026
Merged

fix(selfhost): recognize review_audit in the exporter's no-source-tables guard #3546

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions scripts/export-grafana-reporting-db.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,8 @@ if pg_enabled; then
if ! pg_table_exists "pull_requests" &&
! pg_table_exists "advisories" &&
! pg_table_exists "review_targets" &&
! pg_table_exists "ai_usage_events"; then
! pg_table_exists "ai_usage_events" &&
! pg_table_exists "review_audit"; then
if [ -s "$OUT_DB" ]; then
rm -f "$TMP_DB" "$TMP_DB-wal" "$TMP_DB-shm"
echo "reporting export skipped: no reporting source tables in Postgres; preserving last good $OUT_DB" >&2
Expand Down Expand Up @@ -349,7 +350,8 @@ fi
if ! source_table_exists "pull_requests" &&
! source_table_exists "advisories" &&
! source_table_exists "review_targets" &&
! source_table_exists "ai_usage_events"; then
! source_table_exists "ai_usage_events" &&
! source_table_exists "review_audit"; then
if [ -s "$OUT_DB" ]; then
rm -f "$TMP_DB" "$TMP_DB-wal" "$TMP_DB-shm"
echo "reporting export skipped: no reporting source tables in $APP_DB; preserving last good $OUT_DB" >&2
Expand Down
45 changes: 45 additions & 0 deletions test/unit/selfhost-grafana-reporting.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,51 @@ esac
expect(sqlite(outDb, "SELECT status || '|' || (verdict IS NULL) FROM review_targets WHERE repo='JSONbored/gittensory' AND number=4001;")).toBe("manual|1");
});

it("a source DB with ONLY review_audit (no pull_requests/review_targets/ai_usage_events) is recognized as having real data -- the exporter runs a fresh pass instead of preserving a stale last-good snapshot", () => {
const root = tmpRoot();
const appDb = join(root, "app.sqlite");
const outDb = join(root, "reporting.sqlite");

// Seed a legitimate "last good" output from a normal run, so a wrongly-triggered skip would be observable
// (the old snapshot would survive untouched instead of being replaced by a fresh, empty pass).
sqlite(appDb, `
CREATE TABLE pull_requests (
repo_full_name TEXT NOT NULL, number INTEGER NOT NULL, title TEXT NOT NULL, state TEXT NOT NULL,
author_login TEXT, merged_at TEXT, created_at TEXT NOT NULL, updated_at TEXT NOT NULL
);
INSERT INTO pull_requests (repo_full_name, number, title, state, author_login, merged_at, created_at, updated_at)
VALUES ('JSONbored/gittensory', 9001, 'stale last-good PR', 'open', 'JSONbored', NULL, '2026-07-01T00:00:00Z', '2026-07-01T00:00:00Z');

CREATE TABLE review_audit (
id TEXT NOT NULL, target_id TEXT NOT NULL, event_type TEXT NOT NULL, decision TEXT,
source TEXT NOT NULL, created_at TEXT NOT NULL
);
INSERT INTO review_audit (id, target_id, event_type, decision, source, created_at)
VALUES ('g0', 'JSONbored/gittensory#9001', 'gate_decision', 'hold', 'gittensory-native', '2026-07-01T00:00:00Z');
`);
runExporter(root, appDb, outDb);
expect(sqlite(outDb, "SELECT count(*) FROM review_targets;")).toBe("1");

// Now point at a fresh source DB containing ONLY review_audit -- no pull_requests, review_targets, or
// ai_usage_events at all.
const onlyAuditDb = join(root, "only-audit.sqlite");
sqlite(onlyAuditDb, `
CREATE TABLE review_audit (
id TEXT NOT NULL, target_id TEXT NOT NULL, event_type TEXT NOT NULL, decision TEXT,
source TEXT NOT NULL, created_at TEXT NOT NULL
);
INSERT INTO review_audit (id, target_id, event_type, decision, source, created_at)
VALUES ('g1', 'JSONbored/gittensory#9002', 'gate_decision', 'hold', 'gittensory-native', '2026-07-05T00:00:00Z');
`);
// Must not throw: a wrongly-triggered "no reporting source tables" skip exits non-zero when a last-good
// snapshot already exists (see the seeded run above).
expect(() => runExporter(root, onlyAuditDb, outDb)).not.toThrow();

// The stale PR from the seeded run is GONE -- proving this was a genuine fresh pass (pull_requests doesn't
// exist in the only-review_audit source, so nothing populates review_targets), not a preserved snapshot.
expect(sqlite(outDb, "SELECT count(*) FROM review_targets;")).toBe("0");
});

it("falls back to legacy review_targets when the current PR cache is absent", () => {
const root = tmpRoot();
const appDb = join(root, "app.sqlite");
Expand Down
Loading