Skip to content

feat(enrichment): recognize more binary formats (audio/video/disk/ML) #3585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jeffrey701 wants to merge 1 commit into from
Closed

feat(enrichment): recognize more binary formats (audio/video/disk/ML) #3585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions review-enrichment/src/analyzers/binary-extensions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,22 @@ export const BINARY_FILE_EXTENSIONS = [
"arrow",
"orc",
"msgpack",
// More common binary formats: audio/video containers, disk images, and ML artifacts.
"m4a",
"m4v",
"aac",
"opus",
"wma",
"aiff",
"flv",
"wmv",
"iso",
"dmg",
"pkl",
"pickle",
"joblib",
"tflite",
"keras",
] as const;

const BINARY_EXT_SET = new Set<string>(BINARY_FILE_EXTENSIONS);
Expand Down
7 changes: 7 additions & 0 deletions review-enrichment/test/binary-extensions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,13 @@ test("isBinaryFileExtension and BINARY_EXT_RE agree on known binary paths", () =
"wire/msg.msgpack",
"native/mod.pyd",
"build/Release/addon.node",
"audio/track.m4a",
"audio/sound.opus",
"video/clip.flv",
"release/app.dmg",
"release/image.iso",
"models/scaler.pkl",
"models/model.tflite",
]) {
const ext = path.slice(path.lastIndexOf(".") + 1);
assert.equal(isBinaryFileExtension(ext), true, path);
Expand Down
Loading