feat(enrichment): allowlist 0.0.0.0 in the hardcoded-URL analyzer - #3586
feat(enrichment): allowlist 0.0.0.0 in the hardcoded-URL analyzer#3586jeffrey701 wants to merge 1 commit into
Conversation
ALLOWLISTED_HOSTS treated localhost/127.0.0.1/example.com as placeholders but not 0.0.0.0, the unspecified/localhost bind address — so `http://0.0.0.0:PORT` (a dev/bind placeholder, not a real endpoint) was flagged as a hardcoded URL. Adds it + extends the allowlist test.
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Caution 🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥 🛑 Gittensory review result - reject/close recommendedReview updated: 2026-07-05 18:06:05 UTC
🛑 Suggested Action - Reject/Close
Review summary Blockers
Nits — 6 non-blocking
Why this is blocked
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
|
Gittensory is closing this pull request on the maintainer's behalf (No linked issue detected; Maintainer requires a linked issue; AI reviewers agree on a likely critical defect: The PR description gives no linked/eligible open issue for this change (only a garbled 'rees green (1026)' which reads like a CI/build reference, not an issue number) — per this repo's contributor policy every external PR must close or clearly link an eligible issue, so this should not be marked merge-ready until that's confirmed.). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed. |
ALLOWLISTED_HOSTS treated localhost/127.0.0.1/example.com as placeholders but not 0.0.0.0, the unspecified/localhost bind address — so http://0.0.0.0:PORT (a dev/bind placeholder, not a real endpoint) was flagged as a hardcoded URL. Adds it + extends the allowlist test. rees green (1026).