test(config): lock in review.effort_score plumbing (#2152)

[luciferlive112116]

Closes #2152

Summary

• Add a config-templates inventory test that locks in the shipped review.effort_score plumbing: docs entry in gittensory.full.yml, manifest parse round-trip, and resolveReviewPromptOverrides boolean helper (unset → false).

Validation

• npm run typecheck
• npx vitest run test/unit/config-templates.test.ts

UI Evidence

N/A — test-only.

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[loopover-orb]

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

_{Review updated: 2026-07-06 07:07:49 UTC}

1 file · 1 AI reviewer · no blockers · readiness 62/100 · CI green · clean

⏸️ Suggested Action - Manual Review

Review summary
Test-only PR adding one `it` block that mirrors the existing `changed_files_summary` test (test/unit/config-templates.test.ts:100-113) to cover `review.effort_score`: doc presence in gittensory.full.yml, parseFocusManifest null/true/false round-trip, resolveReviewPromptOverrides boolean coercion, and reviewConfigToJson serialization. The change is narrow, follows an established pattern exactly, and CI passed. Note the PR only locks in existing config-plumbing behavior — it does not add or verify the actual 'review effort: N/5 (~M min)' comment-line feature that issue #2152 describes, so this looks like partial issue coverage rather than a full close.

Nits — 4 non-blocking

• The PR claims to close feat(review): 'review effort: N/5 (~M min)' line in the unified comment, config-gated #2152, but feat(review): 'review effort: N/5 (~M min)' line in the unified comment, config-gated #2152 is about the effort-score line appearing in the unified review comment; this test only covers config parsing/plumbing, not the comment-generation code path — confirm whether a companion PR implements the actual feature or whether this test alone is meant to satisfy the issue.
• The new test duplicates the structure of the `changed_files_summary` test almost verbatim (test/unit/config-templates.test.ts:100-113 vs 116-129); consider a small parameterized helper if more of these boolean-toggle tests get added, though duplication at this scale is acceptable for now.
• If feat(review): 'review effort: N/5 (~M min)' line in the unified comment, config-gated #2152 also requires wiring effort_score into the actual comment renderer, link or bundle that implementation change so the issue is genuinely closed rather than just its config surface being test-covered.
• Readiness score is below the configured threshold — Use the readiness panel as advisory maintainer context; the score does not block this PR.

Signal	Result	Evidence
Code review	✅ No blockers	1 reviewer
Linked issue	✅ Linked	#2152
Related work	⚠️ 3 scoped overlaps	Top overlaps are listed below; lower-confidence bulk is hidden.
Change scope	❌ 8/20	High review scope from cached public metadata (1 linked issue).
Validation posture	❌ 5/25	Preflight is holding this PR: the review lane is unavailable, so it is not ready for automated review.
Contributor workload	✅ 10/10	Author activity: 180 registered-repo PR(s), 94 merged, 18 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	luciferlive112116; Gittensor profile; 180 PR(s), 18 issue(s).
Gate result	✅ Passing	No configured blocker found.

Review context

• Author: luciferlive112116
• Role context: outside_contributor
• Public audience mode: oss maintainer
• Lane context: Repository registration is not available in the local Gittensory cache.
• Public profile languages: JavaScript, MDX, Python, Rust, TypeScript
• Official Gittensor activity: 180 PR(s), 18 issue(s).
• Related work: Titles/paths share 7 meaningful terms. (issue #2152, issue #2150)
• Related work: Titles/paths share 6 meaningful terms. (issue #2189, issue #2156)
• Related work: Titles/paths share 6 meaningful terms. (issue #2156, issue #2152)
• Additional title-only matches omitted; title-only overlap does not block.

Contributor next steps

• Review top overlaps.
• Add a concise scope and risk note.
• Await review-lane availability.
• Refresh registry data or choose a registered active repo.
• Check active issues and PRs before submitting.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

• Re-run Gittensory review

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.29%. Comparing base (b6ad8cd) to head (ca537a9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3740   +/-   ##
=======================================
  Coverage   93.29%   93.29%           
=======================================
  Files         317      317           
  Lines       32347    32347           
  Branches    11871    11871           
=======================================
  Hits        30179    30179           
  Misses       1537     1537           
  Partials      631      631           

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[loopover-orb]

Gittensory approves — the gate is satisfied and CI is green.