test(review): add multi-file band-5 case for estimateReviewEffort (#2151)

[luciferlive112116]

Closes #2151

Summary

• Add the missing multi-file → band-5 case for the shipped estimateReviewEffort pure module (feat(review): deterministic review-effort/complexity estimator (1-5 band + minutes) #2151 deliverable: large multi-file diff lands in band 5).

Validation

• npm run typecheck
• npx vitest run test/unit/review-effort.test.ts

UI Evidence

N/A — test-only.

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.30%. Comparing base (8398615) to head (08f8a8c).
⚠️ Report is 19 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3784   +/-   ##
=======================================
  Coverage   93.30%   93.30%           
=======================================
  Files         317      317           
  Lines       32384    32384           
  Branches    11876    11876           
=======================================
  Hits        30215    30215           
  Misses       1537     1537           
  Partials      632      632           

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[loopover-orb]

Tip

🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩

✅ Gittensory review result - approve/merge recommended

_{Review updated: 2026-07-06 11:29:24 UTC}

1 file · 1 AI reviewer · no blockers · readiness 100/100 · CI green · clean

✅ Suggested Action - Approve/Merge

• safe to merge

Review summary
This PR adds one missing test case to review-effort.test.ts covering a multi-file diff that lands in band 5 (5 files × 100 added lines + per-file overhead = 515 total effort, exceeding the band-4 ceiling of 300), plus a cosmetic rename of the describe block to reference #2151. The math checks out against the existing test suite's established weighting (source weight 1, +3 per-file overhead, minutes = round(effort/2)), and CI is green on this exact commit. It's a narrow, correct, test-only addition that closes the linked issue #2151 as described.

Nits — 4 non-blocking

• The describe-block rename to include "(feat(review): deterministic review-effort/complexity estimator (1-5 band + minutes) #2151)" in test/unit/review-effort.test.ts:12 is a cosmetic change unrelated to the actual test addition — fine, but worth noting it's scope-adjacent rather than part of the core fix.
• The inline comment's arithmetic (5×100 + 5×3 = 515) duplicates the band-5 threshold logic (300) without a reference to where BAND_MAX is defined in review-effort.ts — a pointer to that constant would make the test's intent self-verifying for future readers.
• Consider adding a boundary-case test (effort exactly at 300/301) alongside this one, since the new test only exercises a value well above the band-4 ceiling, not the edge itself.
• No changes needed otherwise — the PR is minimal, correctly scoped to the linked issue, and verified by passing CI.

Signal	Result	Evidence
Code review	✅ No blockers	1 reviewer
Linked issue	✅ Linked	#2151
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (1 linked issue).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 198 registered-repo PR(s), 104 merged, 19 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	luciferlive112116; Gittensor profile; 198 PR(s), 19 issue(s).
Gate result	✅ Passing	No configured blocker found.

Review context

• Author: luciferlive112116
• Role context: outside_contributor
• Public audience mode: oss maintainer
• Lane context: Repository is configured for direct PR review.
• Public profile languages: JavaScript, MDX, Python, Rust, TypeScript
• Official Gittensor activity: 198 PR(s), 19 issue(s).
• PR-specific overlap: none found.

Contributor next steps

• Keep the PR focused and include validation evidence before maintainer review.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

• Re-run Gittensory review

[loopover-orb]

Gittensory approves — the gate is satisfied and CI is green.