Skip to content

fix(agent): exclude private GitHub Projects v2 from suggestion comments #3944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSONbored merged 1 commit into from
Jul 7, 2026
Merged

fix(agent): exclude private GitHub Projects v2 from suggestion comments #3944

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/integrations/project-tracker-adapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ export class GitHubMilestonesAdapter implements ProjectTrackerAdapter {
// Both gaps degrade the SAME way -- an empty projects list, never a crash or a wrong match -- so no special
// handling is needed to stay safe; only visibility (this comment + the PR notes) documents the gap.

type ProjectV2Node = { id: string; title: string; closed: boolean };
type ProjectV2Node = { id: string; title: string; closed: boolean; public: boolean };

type ListOpenProjectsGraphQlResponse = {
repositoryOwner: {
Expand Down Expand Up @@ -204,7 +204,7 @@ export class GitHubProjectsAdapter implements ProjectTrackerAdapter {
__typename
... on Organization {
projectsV2(first: 100, after: $after, orderBy: {field: TITLE, direction: ASC}) {
nodes { id title closed }
nodes { id title closed public }
pageInfo { hasNextPage endCursor }
}
}
Expand All @@ -214,7 +214,7 @@ export class GitHubProjectsAdapter implements ProjectTrackerAdapter {
);
const projectsV2 = response.repositoryOwner?.projectsV2;
if (!projectsV2) break; // owner is a User (or has zero projects) -- see the module-level comment above.
projects.push(...projectsV2.nodes.filter((project) => !project.closed));
projects.push(...projectsV2.nodes.filter((project) => !project.closed && project.public));
if (!projectsV2.pageInfo.hasNextPage) break;
after = projectsV2.pageInfo.endCursor;
}
Expand Down
19 changes: 10 additions & 9 deletions test/unit/project-tracker-adapter.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ describe("GitHubProjectsAdapter (#3184)", () => {
data: {
repositoryOwner: {
__typename: "Organization",
projectsV2: { nodes: [{ id: "PVT_1", title: "Self-host reliability roadmap" }], pageInfo: { hasNextPage: false, endCursor: null } },
projectsV2: { nodes: [{ id: "PVT_1", title: "Self-host reliability roadmap", closed: false, public: true }], pageInfo: { hasNextPage: false, endCursor: null } },
},
},
});
Expand All @@ -204,7 +204,7 @@ describe("GitHubProjectsAdapter (#3184)", () => {
expect(result).toEqual([{ id: "PVT_1", title: "Self-host reliability roadmap" }]);
});

it("listOpenProjects excludes closed Projects v2 boards (regression: gate-flagged closed-board leak, #3184)", async () => {
it("listOpenProjects excludes closed and private Projects v2 boards (regression: gate-flagged closed-board leak, #3184)", async () => {
vi.stubGlobal("fetch", async (input: RequestInfo | URL) => {
const url = input.toString();
if (url.includes("/access_tokens")) return Response.json({ token: "installation-token" });
Expand All @@ -215,8 +215,9 @@ describe("GitHubProjectsAdapter (#3184)", () => {
__typename: "Organization",
projectsV2: {
nodes: [
{ id: "PVT_open", title: "Open roadmap", closed: false },
{ id: "PVT_closed", title: "Closed roadmap", closed: true },
{ id: "PVT_open", title: "Open roadmap", closed: false, public: true },
{ id: "PVT_closed", title: "Closed roadmap", closed: true, public: true },
{ id: "PVT_private", title: "Secret customer roadmap", closed: false, public: false },
],
pageInfo: { hasNextPage: false, endCursor: null },
},
Expand Down Expand Up @@ -254,11 +255,11 @@ describe("GitHubProjectsAdapter (#3184)", () => {
const body = JSON.parse(String(init?.body ?? "{}")) as { variables?: { after?: string | null } };
if (!body.variables?.after) {
return Response.json({
data: { repositoryOwner: { __typename: "Organization", projectsV2: { nodes: [{ id: "PVT_1", title: "Page one project" }], pageInfo: { hasNextPage: true, endCursor: "cursor-2" } } } },
data: { repositoryOwner: { __typename: "Organization", projectsV2: { nodes: [{ id: "PVT_1", title: "Page one project", closed: false, public: true }], pageInfo: { hasNextPage: true, endCursor: "cursor-2" } } } },
});
}
return Response.json({
data: { repositoryOwner: { __typename: "Organization", projectsV2: { nodes: [{ id: "PVT_2", title: "Page two project" }], pageInfo: { hasNextPage: false, endCursor: null } } } },
data: { repositoryOwner: { __typename: "Organization", projectsV2: { nodes: [{ id: "PVT_2", title: "Page two project", closed: false, public: true }], pageInfo: { hasNextPage: false, endCursor: null } } } },
});
}
return new Response("unexpected", { status: 500 });
Expand Down Expand Up @@ -439,7 +440,7 @@ describe("maybeSuggestProjectOrMilestoneMatch (#3183/#3184)", () => {
if (url.includes("/milestones")) return Response.json([]);
if (url.endsWith("/graphql")) {
return Response.json({
data: { repositoryOwner: { __typename: "Organization", projectsV2: { nodes: [{ id: "PVT_1", title: "Self-host reliability roadmap" }], pageInfo: { hasNextPage: false, endCursor: null } } } },
data: { repositoryOwner: { __typename: "Organization", projectsV2: { nodes: [{ id: "PVT_1", title: "Self-host reliability roadmap", closed: false, public: true }], pageInfo: { hasNextPage: false, endCursor: null } } } },
});
}
if (url.includes("/issues/4/comments") && method === "GET") return Response.json([]);
Expand Down Expand Up @@ -474,7 +475,7 @@ describe("maybeSuggestProjectOrMilestoneMatch (#3183/#3184)", () => {
if (url.includes("/milestones")) return Response.json([{ number: 14, title: "Self-host reliability roadmap" }]);
if (url.endsWith("/graphql")) {
return Response.json({
data: { repositoryOwner: { __typename: "Organization", projectsV2: { nodes: [{ id: "PVT_1", title: "Self-host reliability roadmap" }], pageInfo: { hasNextPage: false, endCursor: null } } } },
data: { repositoryOwner: { __typename: "Organization", projectsV2: { nodes: [{ id: "PVT_1", title: "Self-host reliability roadmap", closed: false, public: true }], pageInfo: { hasNextPage: false, endCursor: null } } } },
});
}
if (url.includes("/issues/4/comments") && method === "GET") return Response.json([]);
Expand Down Expand Up @@ -541,7 +542,7 @@ describe("maybeSuggestProjectOrMilestoneMatch (#3183/#3184)", () => {
if (url.includes("/milestones")) return new Response("boom", { status: 500 });
if (url.endsWith("/graphql")) {
return Response.json({
data: { repositoryOwner: { __typename: "Organization", projectsV2: { nodes: [{ id: "PVT_1", title: "Self-host reliability roadmap" }], pageInfo: { hasNextPage: false, endCursor: null } } } },
data: { repositoryOwner: { __typename: "Organization", projectsV2: { nodes: [{ id: "PVT_1", title: "Self-host reliability roadmap", closed: false, public: true }], pageInfo: { hasNextPage: false, endCursor: null } } } },
});
}
if (url.includes("/issues/4/comments") && method === "GET") return Response.json([]);
Expand Down