Skip to content

feat(commands): wire @gittensory resolve dispatch scaffold (#2166) - #3982

Merged
JSONbored merged 1 commit into
JSONbored:mainfrom
claytonlin1110:feat/resolve-command-2166
Jul 7, 2026
Merged

feat(commands): wire @gittensory resolve dispatch scaffold (#2166)#3982
JSONbored merged 1 commit into
JSONbored:mainfrom
claytonlin1110:feat/resolve-command-2166

Conversation

@claytonlin1110

Copy link
Copy Markdown
Contributor

Summary

Closes #2166

Scope

  • The PR title follows type(scope): short summary Conventional Commit format, for example fix(api): restore profile access checks.
  • This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
  • This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
  • I linked a currently open issue this PR resolves (e.g. Closes #123) — a linked open issue is required for every contributor PR.

Validation

  • git diff --check
  • npm run actionlint
  • npm run typecheck
  • npm run test:coverage locally; codecov/patch requires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.
  • npm run test:workers
  • npm run build:mcp
  • npm run test:mcp-pack
  • npm run ui:openapi:check
  • npm run ui:lint
  • npm run ui:typecheck
  • npm run ui:build
  • npm audit --audit-level=moderate
  • New or changed behavior has unit/integration tests for new branches, fallback paths, and sanitizer boundaries

If any required check was skipped, explain why:

  • Scoped tests run locally: npx vitest run test/unit/resolve-command.test.ts test/unit/queue.test.ts -t "#2166" (9 passing). Full npm run test:coverage currently fails on unrelated pre-existing main-branch flakes in this environment (e.g. slop.test.ts, workflow-runner-labels.test.ts); CI is the authoritative gate.

Safety

  • No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
  • Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
  • Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests.
  • API/OpenAPI/MCP behavior is updated and tested where needed.
  • UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks.
  • Visible UI changes include a UI Evidence section below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.
  • Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs.

UI Evidence

N/A — backend command dispatch only.

Notes

  • Mirrors the gate-override handler shape: classifyPrCommandRequest preamble, authorizePrActionActor, skip/denied/completed audit + product-usage events, and resolveAgentActionMode respect for pause/dry-run.

@claytonlin1110
claytonlin1110 requested a review from JSONbored as a code owner July 7, 2026 08:34
@loopover-orb loopover-orb Bot added the gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. label Jul 7, 2026
@loopover-orb

loopover-orb Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Caution

🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥

🛑 Gittensory review result - fixes required

Review updated: 2026-07-07 08:53:30 UTC

4 files · no blockers · readiness 82/100 · CI failing · blocked

🛑 Suggested Action - Fix Blockers

  • AI review already in progress for this PR head: Another Gittensory pass is already running the AI review for this exact PR head. This pass is skipping to avoid a duplicate LLM call.

Review summary
AI review is already running for this PR head in another Gittensory pass. Gittensory is holding this PR for manual review until that pass completes.

Nits — 1 non-blocking
  • AI review already in progress for this PR head — The gate is held for a human reviewer rather than passed automatically; it re-evaluates once the in-flight review completes or on the next update.

CI checks failing

  • validate
  • validate-code
Signal Result Evidence
Code review ✅ No blockers No AI review summary
Linked issue ✅ Linked #2166, #123
Related work ⚠️ 1 scoped overlap Top overlaps are listed below; lower-confidence bulk is hidden.
Change scope ❌ 8/20 High review scope from cached public metadata (2 linked issues).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 437 registered-repo PR(s), 299 merged, 102 issue(s).
Contributor context ✅ Confirmed Gittensor contributor claytonlin1110; Gittensor profile; 437 PR(s), 102 issue(s).
Gate result ⚠️ Not blocking Advisory; not blocking this PR.
Review context
  • Author: claytonlin1110
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: Python, JavaScript, TypeScript, Rust
  • Official Gittensor activity: 437 PR(s), 102 issue(s).
  • Related work: Titles/paths share 9 meaningful terms. (issue #2165, issue #2166)
Contributor next steps
  • Review top overlaps.
  • Add a concise scope and risk note.
  • Check active issues and PRs before submitting.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@loopover-orb

loopover-orb Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Gittensory is closing this pull request on the maintainer's behalf (conflicts with the base branch — resolve and open a fresh PR; Linked issue overlaps another open PR; duplicate of another open PR). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed.

@loopover-orb loopover-orb Bot closed this Jul 7, 2026
@JSONbored JSONbored reopened this Jul 7, 2026
JSONbored
JSONbored previously approved these changes Jul 7, 2026
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@claytonlin1110

Copy link
Copy Markdown
Contributor Author

@JSONbored Resolved conflicts

@codecov

codecov Bot commented Jul 7, 2026

Copy link
Copy Markdown

⚠️ JUnit XML file not found

The CLI was unable to find any JUnit XML files to upload.
For more help, visit our troubleshooting guide.

@JSONbored

JSONbored commented Jul 7, 2026

Copy link
Copy Markdown
Owner

Orb incorrectly closed this one - the link is very stale/outdated (the PR linking to it already

@JSONbored Resolved conflicts

Thanks, i noticed yours was closed when one of mine was auto-merged by orb and caused a merge conflict, still working on properly handling FIFO reviews (to ensure reviews are handled in the order the PR is opened), so I apologize for that. Trying my best to get this fixed as quickly as possible.

Appreciate the quick fixing of conflicts, merging once CI is green.

…#2166)

Record maintainer finding resolutions via audit events and post a public confirmation, without coupling to future suppression semantics.

Co-authored-by: Cursor <cursoragent@cursor.com>
@loopover-orb

loopover-orb Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Gittensory is closing this pull request on the maintainer's behalf (CI is failing (validate, validate-code)). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed.

@loopover-orb loopover-orb Bot closed this Jul 7, 2026
@JSONbored JSONbored reopened this Jul 7, 2026
@JSONbored
JSONbored marked this pull request as draft July 7, 2026 08:55
@loopover-orb

loopover-orb Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Gate verdict stands for this commit — converting to draft does not reset the review. Re-submit a new PR with the issues addressed (ai_consensus_defect).

@loopover-orb loopover-orb Bot closed this Jul 7, 2026
@JSONbored JSONbored reopened this Jul 7, 2026
@JSONbored
JSONbored marked this pull request as ready for review July 7, 2026 08:56
@JSONbored
JSONbored merged commit 6fb51fd into JSONbored:main Jul 7, 2026
6 of 10 checks passed
@claytonlin1110

Copy link
Copy Markdown
Contributor Author

@JSONbored I think it would be great if gittensory-orb doesn't run its review for the draft PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.

Development

Successfully merging this pull request may close these issues.

feat(commands): @gittensory resolve command — parse + classify + mark a review finding resolved (dispatch scaffold)

2 participants