Skip to content

fix(settings): preserve install-wide GLOBAL_CONTRIBUTOR_OPEN_ITEM_CAP (do not clamp to per-repo cap) #4080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSONbored merged 1 commit into from
Jul 8, 2026
Merged

fix(settings): preserve install-wide GLOBAL_CONTRIBUTOR_OPEN_ITEM_CAP (do not clamp to per-repo cap) #4080

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions src/settings/global-contributor-cap.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,20 +8,17 @@
// whole, mirroring how global_contributor_blacklist is a tenant-free singleton rather than a per-repo column.
// Off by default (unset/invalid ⇒ null ⇒ no cap): zero behavior change for a single-repo install or one that
// hasn't opted in.
import { MAX_CONTRIBUTOR_OPEN_ITEM_CAP } from "../types";

const GLOBAL_ENV_KEY = "GLOBAL_CONTRIBUTOR_OPEN_ITEM_CAP";

/** Parse+validate the install-wide open-item cap from env. Same non-rounding shape as the per-repo caps'
* normalizeOpenItemCap (db/repositories.ts): a discrete count of open items, not a score, so a
* fractional/non-positive/non-numeric value is a malformed cap and is dropped to `null` (no cap) rather than
* coerced into a nonsensical threshold. Never throws. Clamped to {@link MAX_CONTRIBUTOR_OPEN_ITEM_CAP} for the
* same reason normalizeOpenItemCap is: live enforcement only ever samples a fixed 100-row budget, so a
* configured value above that is silently unenforceable. */
* coerced into a nonsensical threshold. Never throws. Unlike the per-repo cap, this install-wide cap is not clamped to the
* per-repo live-check budget because the install-wide verifier loads and verifies a larger row set. */
export function resolveGlobalContributorOpenItemCap(env: { GLOBAL_CONTRIBUTOR_OPEN_ITEM_CAP?: string | undefined }): number | null {
const raw = env[GLOBAL_ENV_KEY];
if (typeof raw !== "string" || raw.trim() === "") return null;
const parsed = Number(raw);
if (!Number.isFinite(parsed) || !Number.isInteger(parsed) || parsed <= 0) return null;
return Math.min(parsed, MAX_CONTRIBUTOR_OPEN_ITEM_CAP);
return parsed;
}
7 changes: 3 additions & 4 deletions test/unit/global-contributor-cap.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,9 @@ describe("resolveGlobalContributorOpenItemCap (#2562)", () => {
expect(resolveGlobalContributorOpenItemCap({ GLOBAL_CONTRIBUTOR_OPEN_ITEM_CAP: "1" })).toBe(1);
});

// Live enforcement only ever samples a fixed 100-row budget (MAX_CONTRIBUTOR_OPEN_ITEM_CAP), so a configured
// value above that is silently unenforceable -- mirrors normalizeOpenItemCap's own clamp (db/repositories.ts).
it("clamps a value above the live-check sample budget to 100, and preserves exactly 100 unclamped", () => {
expect(resolveGlobalContributorOpenItemCap({ GLOBAL_CONTRIBUTOR_OPEN_ITEM_CAP: "500" })).toBe(100);
it("preserves install-wide caps above the per-repo live-check sample budget (regression for unintended 100-item clamp)", () => {
expect(resolveGlobalContributorOpenItemCap({ GLOBAL_CONTRIBUTOR_OPEN_ITEM_CAP: "500" })).toBe(500);
expect(resolveGlobalContributorOpenItemCap({ GLOBAL_CONTRIBUTOR_OPEN_ITEM_CAP: "101" })).toBe(101);
expect(resolveGlobalContributorOpenItemCap({ GLOBAL_CONTRIBUTOR_OPEN_ITEM_CAP: "100" })).toBe(100);
});

Expand Down