fix(review): include mutable prompt inputs in linked-issue satisfaction cache fingerprint - #4114
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4114 +/- ##
=======================================
Coverage 93.65% 93.65%
=======================================
Files 384 384
Lines 35865 35871 +6
Branches 13160 13165 +5
=======================================
+ Hits 33589 33595 +6
Misses 1618 1618
Partials 658 658
🚀 New features to boost your workflow:
|
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-08 03:32:43 UTC
⏸️ Suggested Action - Manual Review
Concerns raised — review before merging
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
93eab13 to
4cf730b
Compare
Motivation
Description
linked-issue-satisfaction-input:v2and extendedLinkedIssueSatisfactionCacheInputto includeissueText,prTitle,prBody, anddiff, and included those fields in the fingerprint computation (src/review/linked-issue-satisfaction-cache-input.ts).diffonce in the processor and include the mutable prompt fields and diff when building the cache fingerprint, and pass the same diff into fresh model calls (src/queue/processors.ts).linked_issue_scope_mismatchfinding (test/unit/linked-issue-satisfaction-cache.test.ts,test/unit/linked-issue-satisfaction-run.test.ts).cf-typegendrift check is satisfied (worker-configuration.d.ts).Testing
npx vitest run test/unit/linked-issue-satisfaction-cache.test.ts test/unit/linked-issue-satisfaction-run.test.tsand the targeted suites passed.npm run typecheckand it completed without type errors.npm run cf-typegento refresh runtime types andnpm run cf-typegen:checkpassed after the refresh.git diff --checkpassed; an attempted fullnpm run test:ciencountered an externalnpm auditlookup failure (HTTP 403) in this environment and the end-to-end coverage job was not completed here, but the focused regression tests for this fix passed locally.Codex Task