feat(review): add per-repo review.selftune force-off for the auto-tune cron - #4118
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
gittensory-ui | 8d76894 | Commit Preview URL Branch Preview URL |
Jul 08 2026, 02:10 AM |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4118 +/- ##
=======================================
Coverage 93.65% 93.65%
=======================================
Files 384 384
Lines 35860 35865 +5
Branches 13158 13160 +2
=======================================
+ Hits 33583 33589 +6
Misses 1618 1618
+ Partials 659 658 -1
🚀 New features to boost your workflow:
|
…e cron Unlike rag/reputation/grounding, selftune's cron pass (runSelfTune) has no GITTENSORY_REVIEW_REPOS allowlist to fall back to -- its scoping is already isAgentConfigured (a separate, broader acting-autonomy consent boundary), and it never accepted a shared resolver shape. Adds review.selftune: boolean | null as its own top-level field (mirroring impactMap/cultureProfile, not the features: block -- CONVERGED_FEATURE_KEYS has no allowlist fallback that fits this feature). Deliberately FORCE-OFF-ONLY, mirroring the safety feature's asymmetric precedent (#2269) in the opposite direction: false excludes an otherwise agent-configured repo from tuning; there is no true override, since forcing a non-agent-configured repo INTO tuning would bypass that unrelated consent boundary. Closes #4104.
|
Tip 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 ✅ Gittensory review result - approve/merge recommendedReview updated: 2026-07-08 02:19:41 UTC
✅ Suggested Action - Approve/Merge
Review summary Nits — 6 non-blocking
Linked issue satisfactionPartially addressed Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
066f281 to
8d76894
Compare
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Summary
runSelfTune's cron pass has noGITTENSORY_REVIEW_REPOSallowlist to fall back to — its existing repo scoping isisAgentConfigured(whether a repo already opted into the broader acting-autonomy surface), a different consent boundary entirely.review.selftune: boolean | nullas its own top-levelFocusManifestReviewConfigfield (mirroringimpactMap/cultureProfile's plumbing — NOT thefeatures:/CONVERGED_FEATURE_KEYSblock, which has no allowlist-fallback shape that fits here).safetyfeature's asymmetric precedent (fix(review): features.safety is per-repo disableable via .gittensory.yml even when the operator enabled it globally #2269) in the opposite direction: an explicitreview.selftune: falseexcludes an otherwise agent-configured repo from the tuning pass. There is notrueoverride — forcing a NON-agent-configured repo INTO tuning would bypass that repo's separate, broader autonomy-consent boundary, which this config key must not touch.selfTuneRepos(src/review/selftune-wire.ts) — the per-repo filter function the cron already uses, with a manifest-load error failing open (repo stays included), matching the existing settings-blip fail-safe.Scope
CONTRIBUTING.md.Validation
git diff --checknpm run typecheck— clean.test/unit/focus-manifest.test.ts,test/unit/config-templates.test.ts,test/unit/signals-coverage.test.ts,test/unit/selftune-wiring.test.ts(3 new tests: force-off regression, unset-stays-default regression, true-override-is-a-no-op),test/unit/selftune-readback.test.ts— all green (652 tests).src/review/selftune-wire.tsat 100% line/branch;packages/gittensory-engine/src/focus-manifest.ts's uncovered lines confirmed unrelated to this diff (pre-existinglabelingRules/content-parsing gaps).npm audit --audit-level=moderate— 0 vulnerabilities.Safety
computeTuningRecommendations,runAutoApplyRecommendations) is completely untouched.