refactor(mcp): depend on the published gittensory-engine, drop the hand-ports - #4159
Conversation
…nd-ports Now that @jsonbored/gittensory-engine is published (0.1.0), gittensory-mcp adds it as a real dependency and both packages/gittensory-mcp/lib/local-branch.js and scripts/gittensor-score-preview.mjs import isTestFile/isCodeFile from @jsonbored/gittensory-engine/signals/test-evidence instead of hand-porting the regex logic -- the two remaining copies from the three-way drift that motivated the gittensory-engine consolidation (#4144). package-lock.json: hand-edited a single line rather than running `npm install --package-lock-only`, which was proven (twice, with and without --workspace scoping) to destructively prune ~150 unrelated packages from this monorepo's lockfile. Workspace-to-workspace dependencies only need the manifest-mirror entry updated; the shared node_modules symlink already resolves it. ci.yml: gittensory-mcp's "Build MCP"/"MCP package check" steps and the mcpCliHarness test-skip filter only checked the mcp path filter, not engine -- a PR touching only packages/gittensory-engine/** would have silently skipped rebuilding, pack-checking, and testing its now-real dependent. Verified end-to-end outside the monorepo: packed the mcp tarball, installed it into an isolated scratch directory, confirmed gittensory-engine resolved as a real registry copy (not a workspace symlink) and the classifier functions work through the full published dependency chain.
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
gittensory-ui | 701d626 | Commit Preview URL Branch Preview URL |
Jul 08 2026, 08:30 AM |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4159 +/- ##
=======================================
Coverage 93.73% 93.73%
=======================================
Files 386 386
Lines 36304 36304
Branches 13298 13298
=======================================
Hits 34029 34029
Misses 1618 1618
Partials 657 657 🚀 New features to boost your workflow:
|
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-08 08:41:30 UTC
⏸️ Suggested Action - Manual Review
Review summary Nits — 6 non-blocking
Concerns raised — review before merging
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Summary
Now that `@jsonbored/gittensory-engine` is published (0.1.0), `gittensory-mcp` adds it as a real dependency, and both `packages/gittensory-mcp/lib/local-branch.js` and `scripts/gittensor-score-preview.mjs` import `isTestFile`/`isCodeFile` from `@jsonbored/gittensory-engine/signals/test-evidence` instead of hand-porting the regex logic — the two remaining copies from the three-way drift that motivated the gittensory-engine consolidation (#4144).
Test plan