fix(mcp-cli): add the missing gittensory_get_label_audit CLI descriptor - #4315
Merged
Conversation
#4219 registered the stdio tool with an inline description instead of the shared STDIO_TOOL_DESCRIPTORS + stdioToolDescription(name) pattern every other tool follows, so the `tools --json`/`tools` CLI subcommand (which only reads STDIO_TOOL_DESCRIPTORS) never listed it -- 33 reported vs. 34 actually registered via server.registerTool.
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
gittensory-ui | 30cfaa6 | Commit Preview URL Branch Preview URL |
Jul 08 2026, 08:14 PM |
Contributor
|
Important 🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪 🔍 Gittensory is reviewing…AI analysis is in progress. This comment will update when the review is complete. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed · 🟪 Reviewing |
12 tasks
This was referenced Jul 9, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test/unit/mcp-cli-tools.test.ts's tool-count assertion (expect(payload.count).toBe(registered.length)) has been failing onmain(confirmed on a clean checkout, unrelated to any other change): the stdio MCP server has 34 tools registered viaserver.registerTool, but the CLI'stools/tools --jsonsubcommand only reported 33.gittensory_get_label_auditwith its description written inline in theserver.registerToolcall, instead of following the established pattern every other tool uses — add an entry to the sharedSTDIO_TOOL_DESCRIPTORSarray and reference it viastdioToolDescription(name). The CLI'stools/tools --jsonoutput is built entirely fromSTDIO_TOOL_DESCRIPTORS, so a tool registered only inline never showed up there.registerToolcall to reference it viastdioToolDescription("gittensory_get_label_audit"), matching the neighboring tool's own pattern and preventing this exact class of drift from recurring.Scope
type(scope): short summaryConventional Commit format.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragelocally (unsharded, freshnpm ci) — full suite green, including the previously-failingtest/unit/mcp-cli-tools.test.ts.npm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderatetest/unit/mcp-cli-tools.test.ts) pass; no new test needed since the existing assertion already covers this exact drift class (any future tool registered without a matching descriptor entry will fail the same way).Safety