feat(review): auto-trigger E2E test generation on manifest_missing_tests - #4316
Merged
Merged
Conversation
…sts (#4196) Promotes the existing manifest_missing_tests advisory finding (already computed whenever a repo opts into review.test_expectations + manifestPolicyGateMode) into an actual auto-trigger for the #4192/#4194 generation-and-render path, additive to the explicit `@gittensory generate-tests` command (#4195) -- the explicit command stays available regardless of whether this signal fired. Extracts the generation-and-delivery core shared by both triggers into runE2eTestGenerationAndDeliver, so the two code paths can never silently drift apart. Adds a per-head-SHA double-generation guard (hasAuditEventForHeadSha, mirroring hasAuditEventForDelivery's own json_extract pattern) so a re-review/sweep pass over an unchanged commit never re-spends an LLM call or reposts a duplicate suggestion -- a genuinely new push (a new head SHA) is always a fresh miss. The explicit command deliberately does not consult this guard: a maintainer typing the command always gets a fresh generation, even on a SHA the auto-trigger already covered.
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4316 +/- ##
=======================================
Coverage ? 93.81%
=======================================
Files ? 398
Lines ? 36780
Branches ? 13443
=======================================
Hits ? 34506
Misses ? 1620
Partials ? 654
🚀 New features to boost your workflow:
|
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
manifest_missing_testsadvisory finding (already computed whenever a repo opts intoreview.test_expectations+manifestPolicyGateMode) into an actual auto-trigger for the feat(review): resolver gate for e2eTests — src/review/e2e-test-gen.ts #4192/feat(review): dispatch wiring for e2eTests in queue/processors.ts #4194 generation-and-render path — additive to the explicit@gittensory generate-testscommand (feat(commands): wire @gittensory generate-tests PR-comment command #4195), which stays available regardless of whether this signal fired.runE2eTestGenerationAndDeliver, so the explicit command and the auto-trigger can never silently drift apart.hasAuditEventForHeadSha, mirroringhasAuditEventForDelivery's ownjson_extractpattern) so a re-review/sweep pass over an unchanged commit never re-spends an LLM call or reposts a duplicate suggestion — a genuinely new push (a new head SHA) is always a fresh miss regardless of how many prior SHAs already fired.Closes #4196
Scope
type(scope): short summaryConventional Commit format.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragelocally (unsharded) — 100% branch coverage on every changed/new line in this diff, confirmed via raw lcov BRDA data, not just the summary table.npm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderateauthor ?? "the PR author") attribution fallback.Also ran (this repo's
test:cicovers more than the template lists):npm run db:migrations:check,npm run db:schema-drift:check,npm run selfhost:env-reference:check,npm run selfhost:validate-observability,npm run cf-typegen:check,npm run test:engine-parity, the@jsonbored/gittensory-enginepackage's own tests,npm run build:miner,npm run test:miner-pack,npm run rees:test,npm run ui:openapi:settings-parity,npm run ui:version-audit,npm run docs:drift-check,npm run manifest:drift-check,npm run command-reference:check,npm run ui:test.Safety
Notes