fix(mcp): stop exposing slop rule weights - #4380
Merged
JSONbored merged 1 commit intoJul 9, 2026
Merged
Conversation
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4380 +/- ##
==========================================
- Coverage 93.95% 93.95% -0.01%
==========================================
Files 400 399 -1
Lines 36817 36810 -7
Branches 13451 13451
==========================================
- Hits 34592 34585 -7
Misses 1569 1569
Partials 656 656
🚀 New features to boost your workflow:
|
This was referenced Jul 9, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
gittensory://slop-rulesMCP resource registration fromsrc/mcp/server.tsso the server no longer advertises or returns the slop rules payload.src/review/slop-rules-taxonomy.tsthat serializedSLOP_WEIGHTS/ISSUE_SLOP_WEIGHTSand fixed numeric bands.test/unit/mcp-discovery.test.tsto ensuregittensory://slop-rulesis not advertised.Testing
npm --workspace @jsonbored/gittensory-engine run build, which completed successfully.npx vitest runfor the MCP-related suites (test/unit/mcp-discovery.test.ts,test/unit/mcp-check-slop-risk.test.ts,test/unit/mcp-issue-slop.test.ts,test/unit/mcp-finding-taxonomy.test.ts,test/unit/mcp-enrichment-analyzers.test.ts) and the affected tests passed after the engine build succeeded.npm run typecheckcompleted successfully.npm run test:cifailed due to external/tooling issues (network/DNS foractionlint, stale generated types detected bycf-typegen:check, and annpm auditendpoint 403), not due to the code change itself.Codex Task