Skip to content

fix(commands): limit miner review reruns to cached path #4382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSONbored merged 1 commit into from
Jul 9, 2026
Merged

fix(commands): limit miner review reruns to cached path #4382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/queue/processors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11274,10 +11274,11 @@ async function maybeProcessResolveCommand(env: Env, deliveryId: string, payload:

/**
* `@gittensory review` (#2163, part of #1960, alias `re-review`): a maintainer/collaborator/confirmed-miner
* asks for a fresh AUTO-REVIEW pass on this PR. AUTO-REVIEW SCOPE ONLY, same hard constraint as pause/resolve/
* explain (#1960): this dispatches to the EXISTING reReviewStoredPullRequest path with `force: true` (bypasses
* the AI-review cache/dedup, since a maintainer explicitly typing the command wants a fresh verdict, not a
* cached one) — it never touches the Gate check-run, the AgentActionMode, or the one-shot disposition directly;
* asks for an AUTO-REVIEW pass on this PR. AUTO-REVIEW SCOPE ONLY, same hard constraint as pause/resolve/
* explain (#1960): this dispatches to the EXISTING reReviewStoredPullRequest path. Maintainers and
* collaborators keep the explicit fresh-review behavior; author/miner self-reruns intentionally reuse the
* normal cached path so a low-privilege actor cannot repeatedly spend provider budget or re-roll findings.
* It never touches the Gate check-run, the AgentActionMode, or the one-shot disposition directly;
* whatever reReviewStoredPullRequest's own gate evaluation produces is exactly what a scheduled sweep pass
* would produce. If the PR is currently paused (hasAutoreviewPausedMarker), reReviewStoredPullRequest's own
* existing skipAiReview-on-pause behavior still applies — this command does not special-case or bypass pause;
Expand Down Expand Up @@ -11318,7 +11319,8 @@ async function maybeProcessReviewCommand(env: Env, deliveryId: string, payload:
}
const confirmation = sanitizePublicComment([AGENT_COMMAND_COMMENT_MARKER, "", "> [!NOTE]", `> **Re-review triggered by @${req.actor}**`, "> Re-running auto-review for this PR. The Gate check-run and one-shot disposition are produced the same way a scheduled pass would.", "", "---", gittensoryFooter()].join("\n"));
await createIssueComment(env, req.installationId, req.repoFullName, req.pr.number, confirmation);
await reReviewStoredPullRequest(env, deliveryId, req.installationId, req.repoFullName, req.pr.number, undefined, { force: true });
const forceFreshReview = authorization.actorKind === "maintainer";
await reReviewStoredPullRequest(env, deliveryId, req.installationId, req.repoFullName, req.pr.number, undefined, forceFreshReview ? { force: true } : undefined);
await recordAuditEvent(env, { eventType: "github_app.review_command_completed", actor: req.actor, targetKey, outcome: "completed", detail: "Re-review dispatched.", metadata: { deliveryId, repoFullName: req.repoFullName } });
await recordGithubProductUsage(env, "review_command_completed", { actor: req.actor, repoFullName: req.repoFullName, targetKey, outcome: "completed", metadata: { actorKind: authorization.actorKind } });
return true;
Expand Down
2 changes: 2 additions & 0 deletions test/unit/queue.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11339,6 +11339,8 @@ describe("queue processors", () => {
expect(completed?.outcome).toBe("completed");
const denied = await env.DB.prepare("select 1 from audit_events where event_type = ?").bind("github_app.review_command_denied").first();
expect(denied).toBeFalsy();
const forceBypass = await env.DB.prepare("select 1 from audit_events where event_type = ? and target_key = ?").bind("github_app.ai_review_force_bypass", "JSONbored/gittensory#78").first();
expect(forceBypass).toBeFalsy();
});

it("review: respects agentPaused and agentDryRun without dispatching re-review", async () => {
Expand Down