fix(review): enforce repo gate for e2e generation - #4386
Merged
Conversation
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4386 +/- ##
=======================================
Coverage 93.95% 93.95%
=======================================
Files 400 400
Lines 36817 36819 +2
Branches 13451 13452 +1
=======================================
+ Hits 34592 34594 +2
Misses 1569 1569
Partials 656 656
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
e2eTestskill-switch and not the per-repo converged-feature decision, which could let private PR diffs be sent to an AI provider and consume BYOK/shared quota.Description
convergedFeatureActive(env, input.repoFullName, "e2eTests")early inrunGittensoryE2eTestGenerationand return a disabled result when it is not active (file:src/services/ai-e2e-test-gen.ts).cacheEmptyManifest,enabledEnvWithCachedManifest) and importupsertRepoFocusManifestso tests can exercise the repo manifest path, and add regression tests that assert an unallowlisted repo is disabled and a repo-specificfeatures.e2eTests: trueopt-in enables generation (file:test/unit/ai-e2e-test-gen.test.ts).Testing
npx vitest run test/unit/ai-e2e-test-gen.test.ts; unit tests passed (41 tests).npm run typecheck; TypeScript typecheck passed.npm run test:coverage -- test/unit/ai-e2e-test-gen.test.ts; tests completed successfully but coverage remapping failed withTypeError: jsTokens is not a functionduring V8→lcov conversion.npm audit --audit-level=moderate; the audit step failed with a403 Forbiddenfrom the npm registry and could not complete.Codex Task