Skip to content

fix(review): enforce manifest test gate for ignored authors - #4413

Merged
JSONbored merged 1 commit into
mainfrom
codex/propose-fix-for-manifest-test-gate-bypass
Jul 9, 2026
Merged

fix(review): enforce manifest test gate for ignored authors#4413
JSONbored merged 1 commit into
mainfrom
codex/propose-fix-for-manifest-test-gate-bypass

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Motivation

  • A prior change used the review.auto_review.ignore_authors eligibility decision to filter out the deterministic manifest_missing_tests finding, which allowed ignored authors (e.g. bots) to bypass configured manifest test gates and the downstream e2e-test-generation trigger.
  • This weakened maintainer-enforced test requirements and risked allowing untested PRs to be auto-approved/merged in repos with manifestPolicyGateMode: block and autonomous merge enabled.

Description

  • Restore deterministic manifest policy findings by removing the ignored-author filter so policyFindings is always derived from guidance.findings in src/queue/processors.ts.
  • Preserve the existing e2e auto-trigger that reads the same findings so automated generation still fires when manifest_missing_tests is present.
  • Update the queue regression test in test/unit/queue.test.ts to assert that review.auto_review.ignore_authors only suppresses AI/public review output and does not bypass the manifest_missing_tests gate for ignored bot authors.

Testing

  • Ran npm run typecheck and it completed successfully.
  • Ran the targeted unit tests with npx vitest run test/unit/queue.test.ts -t "ignored bot author|fully-green live CI rollup|PR with a null body" and the selected tests passed (3 passed | 751 skipped).
  • Ran npm audit --audit-level=moderate in this environment and it failed due to the registry audit endpoint returning 403 Forbidden, which is an environmental issue and not related to the code changes.

Codex Task

@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jul 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.96%. Comparing base (90943c9) to head (06467f1).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4413      +/-   ##
==========================================
- Coverage   93.96%   93.96%   -0.01%     
==========================================
  Files         401      401              
  Lines       36902    36901       -1     
  Branches    13494    13493       -1     
==========================================
- Hits        34676    34675       -1     
  Misses       1570     1570              
  Partials      656      656              
Files with missing lines Coverage Δ
src/queue/processors.ts 95.37% <100.00%> (-0.01%) ⬇️
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JSONbored JSONbored self-assigned this Jul 9, 2026
@JSONbored
JSONbored merged commit bd007c3 into main Jul 9, 2026
10 checks passed
@JSONbored
JSONbored deleted the codex/propose-fix-for-manifest-test-gate-bypass branch July 9, 2026 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant