fix(review): enforce manifest test gate for ignored authors - #4413
Merged
Conversation
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4413 +/- ##
==========================================
- Coverage 93.96% 93.96% -0.01%
==========================================
Files 401 401
Lines 36902 36901 -1
Branches 13494 13493 -1
==========================================
- Hits 34676 34675 -1
Misses 1570 1570
Partials 656 656
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
review.auto_review.ignore_authorseligibility decision to filter out the deterministicmanifest_missing_testsfinding, which allowed ignored authors (e.g. bots) to bypass configured manifest test gates and the downstream e2e-test-generation trigger.manifestPolicyGateMode: blockand autonomous merge enabled.Description
policyFindingsis always derived fromguidance.findingsinsrc/queue/processors.ts.manifest_missing_testsis present.test/unit/queue.test.tsto assert thatreview.auto_review.ignore_authorsonly suppresses AI/public review output and does not bypass themanifest_missing_testsgate for ignored bot authors.Testing
npm run typecheckand it completed successfully.npx vitest run test/unit/queue.test.ts -t "ignored bot author|fully-green live CI rollup|PR with a null body"and the selected tests passed (3 passed | 751 skipped).npm audit --audit-level=moderatein this environment and it failed due to the registry audit endpoint returning403 Forbidden, which is an environmental issue and not related to the code changes.Codex Task