feat(review): surface generate-tests command inline in the review comment - #4586
Merged
Conversation
…ment (#4583) manifest_missing_tests already renders in ORB's own comment, but nothing there told a maintainer the @gittensory generate-tests command exists -- mirrors CodeRabbit's inline "Generate unit tests" walkthrough checkbox instead of a separate dashboard toggle, gated on the same e2eTests feature check the #4196 auto-trigger already uses so an unconfigured repo never sees a command that would just bounce. Fixes #4583
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4586 +/- ##
=======================================
Coverage 94.12% 94.12%
=======================================
Files 430 430
Lines 38167 38173 +6
Branches 13917 13919 +2
=======================================
+ Hits 35924 35930 +6
Misses 1585 1585
Partials 658 658
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@gittensory generate-testsand themanifest_missing_testsauto-trigger both work — but nothing in ORB's own review comment ever told amaintainer the command exists. A maintainer would have to already know it from documentation.
checkbox inside their own PR walkthrough comment, not a separate dashboard toggle — discoverable at
the point a maintainer is already looking.
publicSafeManifestPolicyFinding(src/queue/processors.ts) now accepts an optional{ e2eTestGenAvailable }and, only for themanifest_missing_testsfinding and only when thee2eTestsconverged feature is actually enabled for the repo, appends a short CTA to that finding'srendered action text: "Maintainers can also comment
@gittensory generate-testsfor an AI-generatedPlaywright test."
resolveConvergedFeature(env, manifest, "e2eTests", repoFullName)) is hoisted onceand reused by the existing feat(review): auto-trigger E2E test generation on the manifest_missing_tests signal #4196 auto-trigger
ifimmediately below it, rather than computed twice.output for every repo that doesn't have
e2eTestsenabled.Fixes #4583
Test plan
test/unit/public-safe-manifest-finding.test.ts: 2 new cases — CTA appended whene2eTestGenAvailable: trueonmanifest_missing_tests; CTA never leaks onto an unrelated findingcode even when
e2eTestGenAvailable: true— plus the 2 pre-existing cases (redaction, pass-through)continue to cover the default/omitted-options path unchanged
test/unit/queue.test.ts(768 tests, including the existingmanifest_missing_tests auto-trigger (#4196)describe block) — all pass, confirming the hoistede2eTestGenAvailableconst is behavior-preserving for the auto-trigger
ifare exercised and nobranch introduced by this diff is left uncovered
npx tsc --noEmitclean on this diff (a pre-existing, unrelated typecheck failure intest/unit/miner-attempt-log.test.tspredates this branch — confirmed viagit diff origin/mainshowing zero changes to that file)
git diff --checkclean; no drift againstorigin/mainat push timeenv-read, or CLI command-surface changes)