Skip to content

fix(recommendations): prefer requested changes over clean mergeability - #476

Merged
JSONbored merged 2 commits into
JSONbored:mainfrom
philluiz2323:fix/recommendation-outcome-review-precedence
Jun 8, 2026
Merged

fix(recommendations): prefer requested changes over clean mergeability#476
JSONbored merged 2 commits into
JSONbored:mainfrom
philluiz2323:fix/recommendation-outcome-review-precedence

Conversation

@philluiz2323

Copy link
Copy Markdown
Contributor

Summary

  • classify targeted PRs with CHANGES_REQUESTED as rejected before considering clean mergeability
  • normalize cached review decision / mergeable state strings defensively
  • add regression coverage for CHANGES_REQUESTED + clean conflicting signals

Fixes #475.

Tests

  • npm.cmd exec vitest run test/unit/recommendation-outcomes.test.ts
  • npm.cmd run typecheck

@philluiz2323
philluiz2323 requested a review from JSONbored as a code owner June 8, 2026 13:45
@dosubot dosubot Bot added the size:S label Jun 8, 2026
@github-actions github-actions Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jun 8, 2026
@ghost

ghost commented Jun 8, 2026

Copy link
Copy Markdown

Note

Gittensory Gate skipped

PR closed before full evaluation. No late first comment was created.

Signal Result Evidence Action
Gate result ⚠️ Skipped #476 is no longer open. No action.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

@ghost ghost added the gittensory:reviewed label Jun 8, 2026
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@philluiz2323
philluiz2323 force-pushed the fix/recommendation-outcome-review-precedence branch from 798c6d3 to 5fafda6 Compare June 8, 2026 13:55

@JSONbored JSONbored left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@philluiz2323 this is ready from my side.

A few notes:

  • The outcome classifier now correctly treats requested-changes review state as stronger than clean mergeability.
  • The normalization around review decision and mergeable state makes the behavior more robust than the old direct string comparison.
  • The regression coverage is focused on the exact bug.

No code changes requested.

@JSONbored
JSONbored merged commit dd15ecf into JSONbored:main Jun 8, 2026
6 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in gittensory - v1 roadmap Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

[Bug]: Recommendation-outcome classifier reports a changes-requested PR as improved when the branch is also merge-clean

2 participants