fix(recommendations): prefer requested changes over clean mergeability - #476
Merged
JSONbored merged 2 commits intoJun 8, 2026
Conversation
|
Note Gittensory Gate skippedPR closed before full evaluation. No late first comment was created.
Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers. |
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
philluiz2323
force-pushed
the
fix/recommendation-outcome-review-precedence
branch
from
June 8, 2026 13:55
798c6d3 to
5fafda6
Compare
JSONbored
approved these changes
Jun 8, 2026
JSONbored
left a comment
Owner
There was a problem hiding this comment.
@philluiz2323 this is ready from my side.
A few notes:
- The outcome classifier now correctly treats requested-changes review state as stronger than clean mergeability.
- The normalization around review decision and mergeable state makes the behavior more robust than the old direct string comparison.
- The regression coverage is focused on the exact bug.
No code changes requested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CHANGES_REQUESTEDas rejected before considering clean mergeabilityCHANGES_REQUESTED+cleanconflicting signalsFixes #475.
Tests