ci: bump the coverage-run matrix from 4 to 6 shards - #4944
Conversation
Real per-shard timing from the 4-way rollout: ~2026s of aggregate test+import work across 4 shards, ~150s wall time each, ~35s of that fixed setup/teardown overhead per shard job. At 6 shards, projected wall time per shard drops to ~135s (~2.2min), for a total CI critical path around 2.7-2.9min vs the current ~3.5-4min -- while keeping the per-PR job-slot multiplier increase to 1.5x rather than 2x. Deliberately not going straight to 8: this repo sees genuine bursts of 15-20+ concurrent ci.yml runs (measured directly from run history, not an artifact of this session's own churn -- only 2 of 17 concurrent runs in one sampled burst were mine). Doubling per-run job-slot demand during those bursts risks queuing that could offset or reverse the wall-clock win; 6 shards is a smaller, safer step to validate before considering 8.
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4944 +/- ##
=======================================
Coverage 94.24% 94.24%
=======================================
Files 444 444
Lines 38854 38854
Branches 14157 14157
=======================================
Hits 36617 36617
Misses 1577 1577
Partials 660 660
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-11 02:02:06 UTC
⏸️ Suggested Action - Manual Review
Review summary Nits — 3 non-blocking
Concerns raised — review before merging
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Summary
validate-tests's matrix from 4 to 6 shards (--shard=<i>/6), following up ci: shard the full-suite coverage run across a matrix #4815 now that real per-shard timing data exists.Why
Measured from the 4-way rollout: ~2,026s of aggregate test+import work spread across 4 shards, landing at ~150s wall time each (~85% parallel efficiency), with ~35s of fixed per-shard overhead (checkout/cache/build-engine + upload steps). At 6 shards, that projects to ~135s (~2.2min) wall time per shard, cutting the overall CI critical path from ~3.5-4min down to roughly ~2.7-2.9min.
Deliberately not going straight to 8: checked this repo's actual concurrent-run history and found genuine bursts of 15-20+ simultaneous
ci.ymlruns (confirmed only 2 of 17 concurrent runs in one sampled burst were from my own session's retriggers -- the rest were other contributors'/automation's real traffic, mostly automaticpush-to-main runs). Since each PR's shard phase multiplies the job-slots that run demands from the shared concurrent-runner pool, doubling shard count (4→8) doubles that per-run demand during exactly the bursts this repo already produces regularly -- risking queuing that could offset or reverse the wall-clock win. 6 shards is a smaller (1.5x, not 2x) step to validate before considering 8.Test plan
npx tsc --noEmitcleannpm run actionlintcleancodecov-policy.test.ts/workflow-runner-labels.test.tspass (no shard-count-specific assertions broke, only comment text updated)queuedrather thanin_progressduring a busy window -- that would be the signal to back off rather than push to 8