Skip to content

chore(queue): remove 3 orphaned imports from processors.ts - #4970

Merged
JSONbored merged 1 commit into
mainfrom
chore/4013-remove-orphaned-imports
Jul 11, 2026
Merged

chore(queue): remove 3 orphaned imports from processors.ts#4970
JSONbored merged 1 commit into
mainfrom
chore/4013-remove-orphaned-imports

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Summary

  • `isActingAutonomyLevel`, `applyModerationEscalationForRule`, and `checkSummaryText` (imported aliased
    as `checkFailureSummaryText`) have zero remaining call sites in `src/queue/processors.ts` -- leftover
    from an earlier module extraction (refactor(queue): split processors.ts into cohesive modules #4013). `SlopBand` was also checked and still has a real use site, so
    it's left in place.

Test plan

  • `npx tsc --noEmit -p .` clean
  • Full unsharded `npm run test:coverage`: 703 files / 13933 tests passed, 0 failed
  • `npm run docs:drift-check`, `manifest:drift-check`, `engine-parity:drift-check` all pass
  • `npm audit --audit-level=moderate`: 0 vulnerabilities

isActingAutonomyLevel, applyModerationEscalationForRule, and
checkSummaryText (aliased checkFailureSummaryText) have no remaining
call sites -- leftover from an earlier module extraction. SlopBand
still has a real use site and is left in place.
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jul 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.26%. Comparing base (b94589c) to head (ac0d633).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4970   +/-   ##
=======================================
  Coverage   94.26%   94.26%           
=======================================
  Files         448      448           
  Lines       38900    38900           
  Branches    14172    14172           
=======================================
  Hits        36669    36669           
  Misses       1574     1574           
  Partials      657      657           
Flag Coverage Δ
shard-1 46.54% <ø> (-0.29%) ⬇️
shard-2 33.59% <ø> (+0.27%) ⬆️
shard-3 31.56% <ø> (+0.14%) ⬆️
shard-4 32.61% <ø> (-0.54%) ⬇️
shard-5 34.14% <ø> (+0.61%) ⬆️
shard-6 45.86% <ø> (+0.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/queue/processors.ts 95.43% <ø> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 11, 2026
@loopover-orb

loopover-orb Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

Review updated: 2026-07-11 04:53:42 UTC

1 file · 1 AI reviewer · 2 blockers · readiness 100/100 · CI green · unstable

⏸️ Suggested Action - Manual Review

  • No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.
  • AI reviewers agree on a likely critical defect: The PR description does not link or close any eligible open issue in this repo, and per this repo's contribution policy every external contributor PR must reference a maintainer-authorized issue before it can be marked merge-ready — please add that reference or explain why this is exempt. — Resolve the flagged defect, or override if the AI reviewers are mistaken, then re-run the gate.

Review summary
This PR removes three unused imports (isActingAutonomyLevel, applyModerationEscalationForRule, checkSummaryText/checkFailureSummaryText) from src/queue/processors.ts after confirming zero remaining call sites in that file. tsc, full test suite, and drift/audit checks all pass, and the change is correctly scoped to dead-code removal only — SlopBand was checked and correctly left in place since it still has a use site. This is mechanical, low-risk cleanup with no behavioral change.

Blockers

  • The PR description does not link or close any eligible open issue in this repo, and per this repo's contribution policy every external contributor PR must reference a maintainer-authorized issue before it can be marked merge-ready — please add that reference or explain why this is exempt.
Nits — 5 non-blocking
  • No test changes accompany this diff, which is appropriate for dead-import removal, but consider noting in the PR body that tsc's unused-import detection (or a lint rule) is the actual verification mechanism here rather than relying on 'tests passed' as evidence.
  • src/queue/processors.ts is flagged at ~525 lines by the size-smell scan; not introduced by this diff, but worth a follow-up issue to split the file since it keeps growing via import churn like this one.
  • Link this PR to the tracking issue for the refactor(queue): split processors.ts into cohesive modules #4013 module-extraction cleanup (or open one) so the issue-scope requirement is satisfied.
  • If a broader dead-import sweep is planned, consider adding an eslint no-unused-imports rule to CI so these don't need manual PRs going forward.
  • Code changes lack test evidence — Add focused regression tests or explain why existing coverage is sufficient.

Concerns raised — review before merging

  • The PR description does not link or close any eligible open issue in this repo, and per this repo's contribution policy every external contributor PR must reference a maintainer-authorized issue before it can be marked merge-ready — please add that reference or explain why this is exempt.
  • No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.
Signal Result Evidence
Code review ❌ 2 blockers 1 reviewer
Linked issue ✅ No-issue rationale PR body explains why no issue is linked.
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (no linked issue context).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 48 registered-repo PR(s), 40 merged, 423 issue(s).
Contributor context ✅ Confirmed Gittensor contributor JSONbored; Gittensor profile; 48 PR(s), 423 issue(s).
Gate result ❌ Blocking Repo-configured hard blocker found.
Improvement ⚠️ ℹ️ None detected risk: low · value: none — No structural-improvement signals were detected for this PR. LLM value judgment: minor — The change is a safe, correctly-verified removal of three dead imports with no functional impact, which is useful hygiene but very small in scope.
Review context
  • Author: JSONbored
  • Role context: owner (maintainer lane)
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: Python, TypeScript, Ruby, Go, JavaScript, MDX, Shell, Solidity
  • Official Gittensor activity: 48 PR(s), 423 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Treat this as maintainer-lane context rather than normal contributor-lane activity.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@loopover-orb loopover-orb Bot added the manual-review Gittensor contributor context label Jul 11, 2026
@JSONbored
JSONbored merged commit 80a1930 into main Jul 11, 2026
18 checks passed
@JSONbored
JSONbored deleted the chore/4013-remove-orphaned-imports branch July 11, 2026 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. manual-review Gittensor contributor context

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant