feat(miner-governor): fail-closed chokepoint composing every write calculator (#2340)

packages/gittensory-engine/src/governor/chokepoint.ts

@@ -0,0 +1,365 @@
+// The Governor chokepoint (#2340): the single fail-closed decision point every miner write action MUST pass
+// through before executing a `LocalWriteActionSpec` (`src/mcp/local-write-tools.ts`: open_pr, file_issue,
+// apply_labels, post_eligibility_comment, create_branch, delete_branch, generate_tests). This composes the
+// previously-built pure calculators into one verdict -- it is the reason Phase 5 exists.
+//
+// PRECEDENCE ("safest wins", mirroring `resolveAgentActionMode` in `src/settings/agent-execution.ts`):
+//   global kill-switch > per-repo pause > dry-run > rate-limit > budget/turn/termination cap > non-convergence
+//   > self-reputation throttle > self-plagiarism > allow.
+// The issue's own deliverable names rate-limit, budget caps, and non-convergence explicitly. This module also
+// composes self-reputation-throttle and self-plagiarism, per those two calculators' OWN doc comments
+// (`reputation-throttle.ts`: "the chokepoint can record WHY a submission cadence was scaled"; `self-plagiarism.ts`:
+// "the Governor open_pr chokepoint (#2340) composes this verdict with rate-limit, budget caps, and
+// non-convergence") -- both already ship a `*LedgerEvent` builder keyed on their own boolean
+// throttled/allowed field, so composing them here reuses an existing, already-reviewed gate semantic rather
+// than inventing a new one. Both are evaluated only for `actionClass === "open_pr"` (their own ledger builders
+// hardcode/scope to PR submissions; a label-apply or branch-delete has no diff fingerprint or "submission
+// cadence" to throttle).
+//
+// FAIL CLOSED: any stage that throws (malformed caller input escaping this module's typed boundary) denies
+// immediately with `stage: "internal_error"`, never falls through to `allow`.
+//
+// PURE: no IO, no bucket/ledger persistence. This returns a verdict only; the miner-lib wrapper
+// (`packages/gittensory-miner/lib/governor-chokepoint.js`) owns mutating rate-limit buckets and appending the
+// returned ledger event, mirroring the existing engine-pure/miner-lib-stateful split every sibling module uses.
+
+import type { GovernorLedgerEvent, GovernorLedgerEventType } from "../governor-ledger.js";
+import type { PortfolioConvergenceInput, PortfolioConvergenceThresholds, PortfolioConvergenceVerdict } from "../portfolio/non-convergence.js";
+import { classifyPortfolioConvergence, DEFAULT_PORTFOLIO_CONVERGENCE_THRESHOLDS } from "../portfolio/non-convergence.js";
+import { minerActionModeExecutes, resolveMinerActionMode, type MinerActionMode } from "./action-mode.js";
+import type { GovernorCapLimits, GovernorCapReport, GovernorCapUsage } from "./budget-cap.js";
+import { evaluateGovernorCaps } from "./budget-cap.js";
+import { isMinerKillSwitchActive, resolveMinerKillSwitch, type MinerKillSwitchScope } from "./kill-switch.js";
+import type { RepoOutcomeHistory, SelfReputationThresholds, SelfReputationThrottleDecision } from "./reputation-throttle.js";
+import { DEFAULT_SELF_REPUTATION_THRESHOLDS, selfReputationThrottle } from "./reputation-throttle.js";
+import type { OwnSubmissionRecord, SelfPlagiarismCandidate, SelfPlagiarismConfig, SelfPlagiarismVerdict } from "./self-plagiarism.js";
+import { DEFAULT_SELF_PLAGIARISM_CONFIG, selfPlagiarismCheck } from "./self-plagiarism.js";
+import type { WriteRateLimitBackoffStore, WriteRateLimitBucketStore, WriteRateLimitPolicies, WriteRateLimitVerdict } from "./write-rate-limit.js";
+import { evaluateWriteRateLimit } from "./write-rate-limit.js";
+
+/** Which stage of the precedence ladder produced the final verdict. */
+export type GovernorDecisionStage =
+  | "kill_switch"
+  | "dry_run"
+  | "rate_limit"
+  | "budget_cap"
+  | "non_convergence"
+  | "reputation_throttle"
+  | "self_plagiarism"
+  | "allow"
+  | "internal_error";
+
+/** Action classes that carry a per-submission diff fingerprint / outcome-cadence concept. Reputation-throttle
+ *  and self-plagiarism are evaluated only for these -- a label-apply or branch-delete has neither. */
+const SELF_SUBMISSION_ACTION_CLASSES: ReadonlySet<string> = new Set(["open_pr"]);
+
+export type GovernorChokepointInput = {
+  actionClass: string;
+  repoFullName: string;
+  nowMs: number;
+  /** Full would-be action spec, logged verbatim on a dry-run shadow (#2342) or a final denial's audit payload. */
+  wouldBeAction: Record<string, unknown>;
+
+  // Kill-switch (#2341) + action-mode (#2342).
+  killSwitchGlobal: boolean;
+  killSwitchRepoPaused?: boolean | null | undefined;
+  liveModeGlobalOptIn: boolean;
+  liveModeRepoOptIn?: unknown;
+
+  // Rate limit (#2344).
+  rateLimitBuckets: WriteRateLimitBucketStore;
+  rateLimitBackoffAttempts: WriteRateLimitBackoffStore;
+  rateLimitPolicies?: WriteRateLimitPolicies | undefined;
+  rateLimitRandomFn?: (() => number) | undefined;
+
+  // Budget/turn/termination caps.
+  capUsage: GovernorCapUsage;
+  capLimits: GovernorCapLimits;
+
+  // Non-convergence.
+  convergenceInput: PortfolioConvergenceInput;
+  convergenceThresholds?: PortfolioConvergenceThresholds | undefined;
+
+  // Self-reputation throttle + self-plagiarism -- both OPTIONAL: omitted (or actionClass !== "open_pr") skips
+  // the stage entirely rather than fabricating a verdict.
+  reputationHistory?: RepoOutcomeHistory | undefined;
+  reputationThresholds?: SelfReputationThresholds | undefined;
+  selfPlagiarismCandidate?: SelfPlagiarismCandidate | undefined;
+  selfPlagiarismRecentSubmissions?: readonly OwnSubmissionRecord[] | undefined;
+  selfPlagiarismConfig?: SelfPlagiarismConfig | undefined;
+};
+
+export type GovernorDecisionDetail = {
+  killSwitchScope: MinerKillSwitchScope;
+  mode: MinerActionMode;
+  rateLimit?: WriteRateLimitVerdict;
+  budgetCap?: GovernorCapReport;
+  convergence?: PortfolioConvergenceVerdict;
+  reputation?: SelfReputationThrottleDecision;
+  selfPlagiarism?: SelfPlagiarismVerdict;
+};
+
+export type GovernorDecision = {
+  /** True only when every consulted stage allowed AND the resolved mode is `"live"`. */
+  allowed: boolean;
+  mode: MinerActionMode;
+  stage: GovernorDecisionStage;
+  reason: string;
+  detail: GovernorDecisionDetail;
+  /** The single row to append to the governor ledger for this chokepoint invocation. */
+  ledgerEvent: GovernorLedgerEvent;
+};
+
+function denyResult(input: {
+  stage: GovernorDecisionStage;
+  reason: string;
+  mode: MinerActionMode;
+  detail: GovernorDecisionDetail;
+  eventType: GovernorLedgerEventType;
+  actionClass: string;
+  repoFullName: string;
+  extraPayload?: Record<string, unknown>;
+}): GovernorDecision {
+  return {
+    allowed: false,
+    mode: input.mode,
+    stage: input.stage,
+    reason: input.reason,
+    detail: input.detail,
+    ledgerEvent: {
+      eventType: input.eventType,
+      repoFullName: input.repoFullName,
+      actionClass: input.actionClass,
+      decision: input.stage === "kill_switch" ? "paused" : input.eventType === "throttled" ? "throttle" : "deny",
+      reason: input.reason,
+      payload: { stage: input.stage, ...input.extraPayload },
+    },
+  };
+}
+
+/**
+ * Evaluate every write action against the full precedence ladder and return one fail-closed verdict. See the
+ * module doc comment for the exact stage order and which stages are conditional on `actionClass`.
+ */
+export function evaluateGovernorChokepoint(input: GovernorChokepointInput): GovernorDecision {
+  const killSwitchScope = resolveMinerKillSwitch({ global: input.killSwitchGlobal, repoPaused: input.killSwitchRepoPaused });
+  const mode = resolveMinerActionMode({
+    killSwitchScope,
+    repoLiveModeOptIn: input.liveModeRepoOptIn,
+    globalLiveModeOptIn: input.liveModeGlobalOptIn,
+  });
+  const baseDetail: GovernorDecisionDetail = { killSwitchScope, mode };
+
+  if (isMinerKillSwitchActive(killSwitchScope)) {
+    return denyResult({
+      stage: "kill_switch",
+      reason: `${killSwitchScope}_kill_switch_active`,
+      mode,
+      detail: baseDetail,
+      eventType: "kill_switch",
+      actionClass: input.actionClass,
+      repoFullName: input.repoFullName,
+    });
+  }
+
+  if (!minerActionModeExecutes(mode)) {
+    // dry_run: shadow-log the would-be action without evaluating (or executing) anything further. The other
+    // stages are intentionally NOT consulted here -- the ladder's own documented order places dry-run before
+    // rate-limit, and a caller wanting a full "what-would-the-full-verdict-be" preview can call this function
+    // again with a synthetic live opt-in in a non-production dry-run harness.
+    return {
+      allowed: false,
+      mode,
+      stage: "dry_run",
+      reason: "dry_run_mode_active",
+      detail: baseDetail,
+      ledgerEvent: {
+        eventType: "allowed",
+        repoFullName: input.repoFullName,
+        actionClass: input.actionClass,
+        decision: "dry_run",
+        reason: "dry_run_mode_active",
+        payload: { wouldBeAction: input.wouldBeAction },
+      },
+    };
+  }
+
+  let rateLimit: WriteRateLimitVerdict;
+  try {
+    rateLimit = evaluateWriteRateLimit({
+      actionClass: input.actionClass,
+      repoFullName: input.repoFullName,
+      buckets: input.rateLimitBuckets,
+      backoffAttempts: input.rateLimitBackoffAttempts,
+      nowMs: input.nowMs,
+      ...(input.rateLimitPolicies ? { policies: input.rateLimitPolicies } : {}),
+      ...(input.rateLimitRandomFn ? { randomFn: input.rateLimitRandomFn } : {}),
+    });
+  } catch (error) {
+    return denyResult({
+      stage: "internal_error",
+      reason: `rate_limit_calculator_error: ${error instanceof Error ? error.message : String(error)}`,
+      mode,
+      detail: baseDetail,
+      eventType: "denied",
+      actionClass: input.actionClass,
+      repoFullName: input.repoFullName,
+    });
+  }
+  const detailWithRateLimit: GovernorDecisionDetail = { ...baseDetail, rateLimit };
+  if (!rateLimit.allowed) {
+    return denyResult({
+      stage: "rate_limit",
+      reason: rateLimit.reason,
+      mode,
+      detail: detailWithRateLimit,
+      eventType: "throttled",
+      actionClass: input.actionClass,
+      repoFullName: input.repoFullName,
+      extraPayload: { retryAfterMs: rateLimit.retryAfterMs, blockedBy: rateLimit.blockedBy },
+    });
+  }
+
+  let budgetCap: GovernorCapReport;
+  try {
+    budgetCap = evaluateGovernorCaps(input.capUsage, input.capLimits);
+  } catch (error) {
+    return denyResult({
+      stage: "internal_error",
+      reason: `budget_cap_calculator_error: ${error instanceof Error ? error.message : String(error)}`,
+      mode,
+      detail: detailWithRateLimit,
+      eventType: "denied",
+      actionClass: input.actionClass,
+      repoFullName: input.repoFullName,
+    });
+  }
+  const detailWithBudget: GovernorDecisionDetail = { ...detailWithRateLimit, budgetCap };
+  if (budgetCap.verdict !== "allowed") {
+    return denyResult({
+      stage: "budget_cap",
+      reason: `budget_cap_${budgetCap.verdict}`,
+      mode,
+      detail: detailWithBudget,
+      eventType: budgetCap.verdict,
+      actionClass: input.actionClass,
+      repoFullName: input.repoFullName,
+      extraPayload: { budget: budgetCap.budget, turns: budgetCap.turns, termination: budgetCap.termination },
+    });
+  }
+
+  let convergence: PortfolioConvergenceVerdict;
+  try {
+    convergence = classifyPortfolioConvergence(input.convergenceInput, input.convergenceThresholds ?? DEFAULT_PORTFOLIO_CONVERGENCE_THRESHOLDS);
+  } catch (error) {
+    return denyResult({
+      stage: "internal_error",
+      reason: `non_convergence_calculator_error: ${error instanceof Error ? error.message : String(error)}`,
+      mode,
+      detail: detailWithBudget,
+      eventType: "denied",
+      actionClass: input.actionClass,
+      repoFullName: input.repoFullName,
+    });
+  }
+  const detailWithConvergence: GovernorDecisionDetail = { ...detailWithBudget, convergence };
+  if (convergence.status === "non_convergent") {
+    return denyResult({
+      stage: "non_convergence",
+      reason: convergence.reasons.join(" "),
+      mode,
+      detail: detailWithConvergence,
+      eventType: "denied",
+      actionClass: input.actionClass,
+      repoFullName: input.repoFullName,
+    });
+  }
+
+  const isSelfSubmissionAction = SELF_SUBMISSION_ACTION_CLASSES.has(input.actionClass);
+
+  let detailWithReputation = detailWithConvergence;
+  // `!== undefined` (not a truthy check): an omitted key means "skip this stage"; any OTHER value the caller
+  // supplied -- including a bad `null` from a malformed upstream source -- must reach the calculator and, if it
+  // cannot handle it, fail closed via the catch below, never silently skip.
+  if (isSelfSubmissionAction && input.reputationHistory !== undefined) {
+    let reputation: SelfReputationThrottleDecision;
+    try {
+      reputation = selfReputationThrottle(input.reputationHistory, input.reputationThresholds ?? DEFAULT_SELF_REPUTATION_THRESHOLDS);
+    } catch (error) {
+      return denyResult({
+        stage: "internal_error",
+        reason: `reputation_throttle_calculator_error: ${error instanceof Error ? error.message : String(error)}`,
+        mode,
+        detail: detailWithConvergence,
+        eventType: "denied",
+        actionClass: input.actionClass,
+        repoFullName: input.repoFullName,
+      });
+    }
+    detailWithReputation = { ...detailWithConvergence, reputation };
+    if (reputation.throttled) {
+      return denyResult({
+        stage: "reputation_throttle",
+        reason: reputation.reason,
+        mode,
+        detail: detailWithReputation,
+        eventType: "throttled",
+        actionClass: input.actionClass,
+        repoFullName: input.repoFullName,
+        extraPayload: { cadenceFactor: reputation.cadenceFactor, unfavorableRatio: reputation.unfavorableRatio },
+      });
+    }
+  }
+
+  let finalDetail = detailWithReputation;
+  // Same `!== undefined` reasoning as the reputation-throttle stage above.
+  if (isSelfSubmissionAction && input.selfPlagiarismCandidate !== undefined) {
+    let selfPlagiarism: SelfPlagiarismVerdict;
+    try {
+      selfPlagiarism = selfPlagiarismCheck(
+        input.selfPlagiarismCandidate,
+        input.selfPlagiarismRecentSubmissions ?? [],
+        input.selfPlagiarismConfig ?? DEFAULT_SELF_PLAGIARISM_CONFIG,
+      );
+    } catch (error) {
+      return denyResult({
+        stage: "internal_error",
+        reason: `self_plagiarism_calculator_error: ${error instanceof Error ? error.message : String(error)}`,
+        mode,
+        detail: detailWithReputation,
+        eventType: "denied",
+        actionClass: input.actionClass,
+        repoFullName: input.repoFullName,
+      });
+    }
+    finalDetail = { ...detailWithReputation, selfPlagiarism };
+    if (!selfPlagiarism.allowed) {
+      return denyResult({
+        stage: "self_plagiarism",
+        reason: selfPlagiarism.reason,
+        mode,
+        detail: finalDetail,
+        eventType: selfPlagiarism.eventType,
+        actionClass: input.actionClass,
+        repoFullName: input.repoFullName,
+        extraPayload: { similarity: selfPlagiarism.similarity ?? null },
+      });
+    }
+  }
+
+  return {
+    allowed: true,
+    mode,
+    stage: "allow",
+    reason: "all_governor_checks_passed",
+    detail: finalDetail,
+    ledgerEvent: {
+      eventType: "allowed",
+      repoFullName: input.repoFullName,
+      actionClass: input.actionClass,
+      decision: "allow",
+      reason: "all_governor_checks_passed",
+      payload: {},
+    },
+  };
+}

packages/gittensory-engine/src/index.ts

@@ -151,6 +151,7 @@ export * from "./governor/write-rate-limit.js";
 export * from "./governor/run-halt.js";
 export * from "./governor/kill-switch.js";
 export * from "./governor/action-mode.js";
+export * from "./governor/chokepoint.js";
 export {
   GOVERNOR_LEDGER_EVENT_TYPES,
   normalizeGovernorLedgerEvent,