Skip to content

fix(commands): guard command authorization preview lookups - #503

Merged
JSONbored merged 1 commit into
mainfrom
codex/fix-settings-preview-crash-from-command-names
Jun 10, 2026
Merged

fix(commands): guard command authorization preview lookups#503
JSONbored merged 1 commit into
mainfrom
codex/fix-settings-preview-crash-from-command-names

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Motivation

  • Prevent a crash in the settings preview when untrusted commandName values that are inherited object properties (for example constructor, toString, __proto__) are indexed on normalized.commands and then passed to dedupeRoles, which caused a TypeError and availability impact.

Description

  • Use Object.hasOwn(normalized.commands, commandName) before reading normalized.commands[commandName] so prototype properties do not get treated as command role arrays and instead fall back to normalized.default, and add unit coverage in test/unit/command-authorization.test.ts exercising inherited property names through commandAuthorizationAllowedRoles and evaluateCommandAuthorization.

Testing

  • Ran npx vitest run test/unit/command-authorization.test.ts --pool=threads --reporter=default and npm run typecheck, both succeeded, and git diff --check reported no issues.

Codex Task

@dosubot dosubot Bot added the size:XS label Jun 9, 2026
@github-actions github-actions Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jun 9, 2026
@ghost

ghost commented Jun 9, 2026

Copy link
Copy Markdown

Note

Gittensory Gate skipped

PR closed before full evaluation. No late first comment was created.

Signal Result Evidence Action
Gate result ⚠️ Skipped #503 is no longer open. No action.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

@ghost ghost added the gittensory:reviewed label Jun 9, 2026
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 9, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
gittensory-ui 0738737 Commit Preview URL

Branch Preview URL
Jun 10 2026, 07:32 AM

@JSONbored JSONbored self-assigned this Jun 10, 2026
@JSONbored JSONbored changed the title fix: guard command authorization preview lookups fix(commands): guard command authorization preview lookups Jun 10, 2026
@JSONbored
JSONbored force-pushed the codex/fix-settings-preview-crash-from-command-names branch from 06aff27 to 6dc47be Compare June 10, 2026 07:20
@JSONbored
JSONbored force-pushed the codex/fix-settings-preview-crash-from-command-names branch from 6dc47be to 0738737 Compare June 10, 2026 07:31
@JSONbored
JSONbored merged commit 36762e3 into main Jun 10, 2026
10 checks passed
@JSONbored
JSONbored deleted the codex/fix-settings-preview-crash-from-command-names branch June 10, 2026 07:34
@github-project-automation github-project-automation Bot moved this from Todo to Done in gittensory - v1 roadmap Jun 10, 2026
@JSONbored JSONbored added the gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. label Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant