feat(miner-ui): add an optional ORB/Grafana footer link to the root layout - #5401
feat(miner-ui): add an optional ORB/Grafana footer link to the root layout#5401davion-knight wants to merge 1 commit into
Conversation
…ayout Render a footer link to an operator-configured ORB/Grafana dashboard (JSONbored#5194), shown only when VITE_MINER_UI_GRAFANA_URL is set and non-empty (nothing rendered otherwise). Vite exposes only VITE_-prefixed vars to the client bundle, so the name is VITE_-prefixed — a bare name would be undefined at build. Opens in a new tab (target=_blank rel=noopener noreferrer); the URL is rendered as a plain href (React escapes it, no dangerouslySetInnerHTML) and no token/credential is ever appended. Extracted as a small GrafanaFooterLink component for direct testing. Closes JSONbored#5194
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Caution 🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥 🛑 Gittensory review result - reject/close recommendedReview updated: 2026-07-12 16:43:53 UTC
🛑 Suggested Action - Reject/Close
Review summary Blockers
Nits — 5 non-blocking
Why this is blocked
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
[BETA] Chat with GittensoryAsk Gittensory a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://gittensory.aethereal.dev/docs/gittensory-commands Visual preview
Click any thumbnail to open the full-size screenshot. Before = production · After = this PR's preview deploy. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
|
Gittensory is closing this pull request on the maintainer's behalf (AI reviewers agree on a likely critical defect: apps/gittensory-miner-ui/src/routes/__root.tsx:32 renders the footer wrapper unconditionally, so when `VITE_MINER_UI_GRAFANA_URL` is unset `GrafanaFooterLink` returns null but users still get an empty `py-4` footer instead of no visible footer/placeholder; move the conditional to the layout or have `GrafanaFooterLink` own the footer wrapper and return null for the whole footer.). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed. |
Renders a footer link to an operator-configured ORB/Grafana dashboard in the miner-ui root layout (#5194).
Behavior (matches the issue exactly)
VITE_MINER_UI_GRAFANA_URL.VITE_-prefixed because Vite only exposesVITE_*to the client bundle (a bare name would be silentlyundefinedat build).target="_blank" rel="noopener noreferrer".href; no token/session/API key is ever appended.hrefattribute (React escapes it; nodangerouslySetInnerHTML), so a misconfigured value cannot inject markup.GrafanaFooterLinkcomponent; no other footer/layout/auth logic changed. Documented in the miner-ui README.Validation
src/grafana-footer-link.test.tsx(3 tests): env-set → link with correcthref/target/rel; env-unset/empty → nothing renders; invariant →hrefis the URL verbatim with no token/credential appended.tscclean (my files); prettier-clean; no secrets.apps/**is codecov-ignored, socodecov/patchis vacuous — the branch-covering suite ships regardless.Closes #5194