chore(miner): remove gate-verdict-poller.js as dead code - #5512
Merged
Conversation
The module (#4273) has zero production callers and, per its own header, the single-PR gate-decision endpoint it was built against was never real. loop-cli.js already gets the authoritative terminal merge/close signal from pr-disposition-poller.js's real GitHub PR-state polling (ci-poller.js's check-run conclusion is a heuristic proxy alongside it), so the module's purpose is fully covered by existing, wired code. The alternative of rewriting it against open-pr-monitor's classification vocabulary doesn't work: that endpoint only returns open PRs, so it is structurally incapable of ever reporting a terminal merge/close verdict. Closes #5450
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
gittensory-ui | 6b81e19 | Commit Preview URL Branch Preview URL |
Jul 13 2026, 12:03 AM |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5512 +/- ##
==========================================
- Coverage 94.77% 94.77% -0.01%
==========================================
Files 566 565 -1
Lines 44982 44949 -33
Branches 14675 14675
==========================================
- Hits 42631 42599 -32
+ Misses 1617 1616 -1
Partials 734 734
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gate-verdict-poller.js(feat(miner-manage): maintainer-gate verdict watcher (read-only, webhook or poll) #4273) — it has zero production callers, and per its own header, the single-PR gate-decision endpoint it was built to poll was never real.loop-cli.jsalready gets the authoritative terminal merge/close outcome frompr-disposition-poller.js's real GitHub PR-state polling (ci-poller.js's check-run conclusion runs alongside it as a heuristic proxy for in-flight CI state) — this module's intended purpose is already fully covered.open-pr-monitor'sclassification: OpenPrWorkClassificationvocabulary) doesn't work: that endpoint filters tostate === "open"only, so it's structurally incapable of ever expressing a terminal merge/close verdict.loop-cli.js,http-retry.js) and thepackage.jsonbuild-check entry; deleted the now-orphaned test file.Test plan
npx vitest run test/unit test/contract— 778 files / 15172 tests passing, 0 regressionsnpm run build --workspace @jsonbored/gittensory-miner(node --checkover every remaining lib file)npx tsc --noEmitcleannpm run docs:drift-check && npm run manifest:drift-check && npm run engine-parity:drift-check && npm run miner:env-reference:checknpm audit --audit-level=moderate— 0 vulnerabilitiesgate-verdict-poller/gateVerdictPoller/pollGateVerdict/GATE_VERDICTS— zero remaining referencesCloses #5450