fix(ci): build gittensory-engine before ui:build's miner-ui step - #5586
Merged
Conversation
PR #5567 added `npm --workspace @jsonbored/gittensory-miner-ui run build` to the ui:build script chain, but gittensory-miner-ui's vite config transitively dynamic-imports @jsonbored/gittensory-miner's portfolio-dashboard.js (via vite-portfolio-queue-api.ts), which depends on @jsonbored/gittensory-engine. ui:build never builds the engine first, so its dist/ doesn't exist and vite's config bundler fails: "Failed to resolve entry for package '@jsonbored/gittensory- engine'". This worked by accident in `npm run test:ci` (an earlier step, build:miner, happens to build the engine first in that chain) but fails standalone wherever ui:build runs in isolation — confirmed via ui-preview.yml failing identically on this branch and on an unrelated renovate/npm-minor-patch branch at the same time, meaning it's been broken on main for every PR touching apps/gittensory-ui/** or packages/** since #5567 merged. ui:lint and ui:typecheck are unaffected: TS/ESLint resolve @jsonbored/gittensory-engine via tsconfig path-mapping to source, not the compiled package entry.
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5586 +/- ##
=======================================
Coverage 94.99% 94.99%
=======================================
Files 573 573
Lines 45490 45490
Branches 14680 14680
=======================================
Hits 43212 43212
Misses 1527 1527
Partials 751 751
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm --workspace @jsonbored/gittensory-miner-ui run buildto theui:buildscript chain, butgittensory-miner-ui's vite config transitively dynamic-imports@jsonbored/gittensory-miner'sportfolio-dashboard.js(viavite-portfolio-queue-api.ts), which depends on@jsonbored/gittensory-engine.ui:buildnever builds the engine first, so itsdist/doesn't exist and vite's config bundler fails:Failed to resolve entry for package "@jsonbored/gittensory-engine".npm run test:ci(an earlier step,build:miner, happens to build the engine first in that chain) but fails standalone whereverui:buildruns in isolation — confirmed viaui-preview.yml's "Build UI preview artifact" job failing identically on this branch and on an unrelatedrenovate/npm-minor-patchbranch at the same time, meaning it's been broken onmainfor every PR touchingapps/gittensory-ui/**orpackages/**since feat(miner-extension): add workspace package and CI wiring #5567 merged.ui:lint/ui:typecheckare unaffected: TS/ESLint resolve@jsonbored/gittensory-enginevia tsconfig path-mapping to source, not the compiled package entry — confirmed both pass with the engine'sdist/absent.Test plan
npm ci(no enginedist/), confirmed the fix resolves it.npm run test:ci+npm audit --audit-level=moderate) green.