Skip to content

fix(ci): build gittensory-engine before ui:build's miner-ui step - #5586

Merged
JSONbored merged 1 commit into
mainfrom
fix/ui-build-missing-engine-prebuild
Jul 13, 2026
Merged

fix(ci): build gittensory-engine before ui:build's miner-ui step#5586
JSONbored merged 1 commit into
mainfrom
fix/ui-build-missing-engine-prebuild

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Summary

  • PR feat(miner-extension): add workspace package and CI wiring #5567 added npm --workspace @jsonbored/gittensory-miner-ui run build to the ui:build script chain, but gittensory-miner-ui's vite config transitively dynamic-imports @jsonbored/gittensory-miner's portfolio-dashboard.js (via vite-portfolio-queue-api.ts), which depends on @jsonbored/gittensory-engine.
  • ui:build never builds the engine first, so its dist/ doesn't exist and vite's config bundler fails: Failed to resolve entry for package "@jsonbored/gittensory-engine".
  • This worked by accident inside npm run test:ci (an earlier step, build:miner, happens to build the engine first in that chain) but fails standalone wherever ui:build runs in isolation — confirmed via ui-preview.yml's "Build UI preview artifact" job failing identically on this branch and on an unrelated renovate/npm-minor-patch branch at the same time, meaning it's been broken on main for every PR touching apps/gittensory-ui/** or packages/** since feat(miner-extension): add workspace package and CI wiring #5567 merged.
  • ui:lint/ui:typecheck are unaffected: TS/ESLint resolve @jsonbored/gittensory-engine via tsconfig path-mapping to source, not the compiled package entry — confirmed both pass with the engine's dist/ absent.

Test plan

  • Reproduced the failure locally with a fresh worktree + npm ci (no engine dist/), confirmed the fix resolves it.
  • Full local gate (npm run test:ci + npm audit --audit-level=moderate) green.

PR #5567 added `npm --workspace @jsonbored/gittensory-miner-ui run
build` to the ui:build script chain, but gittensory-miner-ui's vite
config transitively dynamic-imports @jsonbored/gittensory-miner's
portfolio-dashboard.js (via vite-portfolio-queue-api.ts), which
depends on @jsonbored/gittensory-engine. ui:build never builds the
engine first, so its dist/ doesn't exist and vite's config bundler
fails: "Failed to resolve entry for package '@jsonbored/gittensory-
engine'".

This worked by accident in `npm run test:ci` (an earlier step,
build:miner, happens to build the engine first in that chain) but
fails standalone wherever ui:build runs in isolation — confirmed via
ui-preview.yml failing identically on this branch and on an unrelated
renovate/npm-minor-patch branch at the same time, meaning it's been
broken on main for every PR touching apps/gittensory-ui/** or
packages/** since #5567 merged.

ui:lint and ui:typecheck are unaffected: TS/ESLint resolve
@jsonbored/gittensory-engine via tsconfig path-mapping to source,
not the compiled package entry.
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@JSONbored JSONbored self-assigned this Jul 13, 2026
@JSONbored
JSONbored merged commit d402777 into main Jul 13, 2026
13 checks passed
@JSONbored
JSONbored deleted the fix/ui-build-missing-engine-prebuild branch July 13, 2026 07:24
@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 13, 2026
@codecov

codecov Bot commented Jul 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.99%. Comparing base (1cf4c0e) to head (c1a9947).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5586   +/-   ##
=======================================
  Coverage   94.99%   94.99%           
=======================================
  Files         573      573           
  Lines       45490    45490           
  Branches    14680    14680           
=======================================
  Hits        43212    43212           
  Misses       1527     1527           
  Partials      751      751           
Flag Coverage Δ
shard-1 44.03% <ø> (ø)
shard-2 35.66% <ø> (ø)
shard-3 32.16% <ø> (ø)
shard-4 32.86% <ø> (ø)
shard-5 31.86% <ø> (ø)
shard-6 44.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant