feat(observability): add an AMS cross-link panel to the resource hub - #5640
Conversation
Adds an additive markdown panel to grafana/dashboards/resource-hub.json so a dual-role operator running both ORB and AMS on one box can discover the AMS observability material from the hub, the same way the hub already cross-links its other integrated services. The panel links to the in-repo 'Observing your miner' guide (packages/gittensory-miner/docs/observability.md) -- the AMS observability entry point (same target as the merged JSONbored#5191 callout) -- rather than a not-yet-published dashboard, so the link is never dead. A dedicated test asserts the panel exists, is additive (the two original panels stay untouched, panel ids stay unique), and that its link target resolves to a real in-repo file. Closes JSONbored#5189
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Tip 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-13 18:49:02 UTC
✅ Suggested Action - Approve/Merge
Review summary Nits — 3 non-blocking
Review context
Contributor next steps
Signal definitions
[BETA] Chat with GittensoryAsk Gittensory a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://gittensory.aethereal.dev/docs/gittensory-commands 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Adds an AMS cross-link to
grafana/dashboards/resource-hub.jsonso an operator running both ORB and AMS on one box can discover the AMS observability material from the hub — the same way the hub already cross-links its other integrated services.What this adds
A new additive markdown text panel ("🤖 AMS — Autonomous Miner System"), matching the hub's existing integrated-services panel style (same
text/markdown panel type, grid sizing, and title/description conventions). It includes the short "AMS is a separate localgittensory-minerCLI a dual-role operator may also be running" note (context, per the issue).Link target — never a dead link
The issue references
miner-usage.json, but that dashboard is not published yet. Rather than ship a dead link, the panel points to the in-repo "Observing your miner" guide (packages/gittensory-miner/docs/observability.md) — the single AMS observability entry point, which itself covers pointing Grafana at the redacted AMS ledger datasources and loading its dashboard. This is the same target the just-merged #5191 callout uses, keeping the two consistent.Additive only + tested
test/unit/selfhost-grafana-resource-hub-dashboard.test.tsasserts: the hub identity + original panels are intact, exactly one AMS markdown panel is added, panel ids stay unique, and — the dead-link invariant — the panel's link target resolves to a real in-repo file (existsSync).Validation (local)
npm run selfhost:validate-observability: OK (dashboard JSON shape valid).vitest(new test): 4/4.git diff --check: clean. Cut from latestmain.Closes #5189