Skip to content

feat(observability): add an AMS cross-link panel to the resource hub - #5640

Merged
JSONbored merged 1 commit into
JSONbored:mainfrom
jaytbarimbao-collab:feat-ams-hub-crosslink
Jul 13, 2026
Merged

feat(observability): add an AMS cross-link panel to the resource hub#5640
JSONbored merged 1 commit into
JSONbored:mainfrom
jaytbarimbao-collab:feat-ams-hub-crosslink

Conversation

@jaytbarimbao-collab

Copy link
Copy Markdown
Contributor

Adds an AMS cross-link to grafana/dashboards/resource-hub.json so an operator running both ORB and AMS on one box can discover the AMS observability material from the hub — the same way the hub already cross-links its other integrated services.

What this adds

A new additive markdown text panel ("🤖 AMS — Autonomous Miner System"), matching the hub's existing integrated-services panel style (same text/markdown panel type, grid sizing, and title/description conventions). It includes the short "AMS is a separate local gittensory-miner CLI a dual-role operator may also be running" note (context, per the issue).

Link target — never a dead link

The issue references miner-usage.json, but that dashboard is not published yet. Rather than ship a dead link, the panel points to the in-repo "Observing your miner" guide (packages/gittensory-miner/docs/observability.md) — the single AMS observability entry point, which itself covers pointing Grafana at the redacted AMS ledger datasources and loading its dashboard. This is the same target the just-merged #5191 callout uses, keeping the two consistent.

Additive only + tested

  • Does not modify any existing panel, datasource, or variable — the two original panels are untouched (req 5).
  • test/unit/selfhost-grafana-resource-hub-dashboard.test.ts asserts: the hub identity + original panels are intact, exactly one AMS markdown panel is added, panel ids stay unique, and — the dead-link invariant — the panel's link target resolves to a real in-repo file (existsSync).

Validation (local)

  • npm run selfhost:validate-observability: OK (dashboard JSON shape valid).
  • vitest (new test): 4/4.
  • git diff --check: clean. Cut from latest main.

Closes #5189

Adds an additive markdown panel to grafana/dashboards/resource-hub.json so a
dual-role operator running both ORB and AMS on one box can discover the AMS
observability material from the hub, the same way the hub already cross-links
its other integrated services.

The panel links to the in-repo 'Observing your miner' guide
(packages/gittensory-miner/docs/observability.md) -- the AMS observability
entry point (same target as the merged JSONbored#5191 callout) -- rather than a
not-yet-published dashboard, so the link is never dead. A dedicated test
asserts the panel exists, is additive (the two original panels stay untouched,
panel ids stay unique), and that its link target resolves to a real in-repo
file.

Closes JSONbored#5189
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@loopover-orb loopover-orb Bot added the gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. label Jul 13, 2026
@loopover-orb

loopover-orb Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Tip

🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩

✅ LoopOver review result - approve/merge recommended

Review updated: 2026-07-13 18:49:02 UTC

2 files · 1 AI reviewer · no blockers · readiness 100/100 · CI green · clean

✅ Suggested Action - Approve/Merge

  • safe to merge

Review summary
This adds a single additive markdown text panel to the Grafana resource-hub dashboard, cross-linking to the in-repo AMS observability guide, plus a well-targeted test file that verifies dashboard identity, panel uniqueness, and (via existsSync) that the link target is not dead. The change is correctly scoped to the linked issue #5189, doesn't touch the two existing panels, and the id/gridPos values are sane and non-colliding with the existing panels (id 3, y:13 sits below the h:13 panels at y:0).

Nits — 3 non-blocking
  • The test comment claims panel id collisions 'silently break Grafana panel rendering' — worth double-checking that's actually Grafana's failure mode rather than just a general JSON hygiene assumption, since it's asserted without a citation.
  • grafana/dashboards/resource-hub.json:79 — the AMS panel content links to a GitHub blob URL rather than a local Grafana panel link (`/d/...`) like the other panels use, which is consistent with the PR's stated reasoning (no published AMS dashboard yet) but is a slight stylistic inconsistency worth calling out in the panel or PR description.
  • Consider confirming the dead-link invariant test would also catch a typo in the URL segment itself (e.g., if someone edits AMS_GUIDE_URL construction) since it currently only checks the raw repo path with existsSync, not that the URL string is well-formed relative to GitHub's actual blob URL convention.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ✅ Linked #5189
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 45 registered-repo PR(s), 22 merged, 4 issue(s).
Contributor context ✅ Confirmed Gittensor contributor jaytbarimbao-collab; Gittensor profile; 45 PR(s), 4 issue(s).
Gate result ✅ Passing No configured blocker found.
Improvement ⚠️ ℹ️ Insufficient signal risk: clean · value: insufficient-signal — Nothing measurable for the structural-improvement analyzers on this PR (e.g. no code files changed).
Review context
  • Author: jaytbarimbao-collab
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: not available
  • Official Gittensor activity: 45 PR(s), 4 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Keep the PR focused and include validation evidence before maintainer review.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
[BETA] Chat with Gittensory

Ask Gittensory a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @gittensory ask <question> answers contribution-quality Q&A with source citations and freshness.
  • @gittensory chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @gittensory mention with a real question is routed to the closest matching read-only command automatically -- no exact syntax required.

Full command reference: https://gittensory.aethereal.dev/docs/gittensory-commands

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@loopover-orb loopover-orb Bot added the manual-review Gittensor contributor context label Jul 13, 2026
@JSONbored
JSONbored merged commit df87201 into JSONbored:main Jul 13, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. manual-review Gittensor contributor context

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add an AMS cross-link panel to resource-hub.json

2 participants