fix(mcp): make decision-pack and repo-decision CLI commands honor --help - #5995
Conversation
Both commands were fully wired into runCli's dispatch table and CLI_COMMAND_SPEC but never checked options.help, so --help fell through to the normal --login/--repo requirement and threw a login error instead of printing usage, unlike every other single-purpose subcommand in this CLI family. Closes JSONbored#5927
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Tip 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-15 06:15:12 UTC
✅ Suggested Action - Approve/Merge
Review summary Nits — 3 non-blocking
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://gittensory.aethereal.dev/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Summary
decisionPackCliandrepoDecisionCliinpackages/loopover-mcp/bin/loopover-mcp.jswere wired intorunCli's dispatch table andCLI_COMMAND_SPEClike every other single-purpose subcommand, but unlikereviewPrCli,lintPrTextCli,validateConfigCli,slopRiskCli, andissueSlopCli, neither one checked for--help, soloopover-mcp decision-pack --helpfell straight into the--loginrequirement and threw a login error instead of printing usage.printDecisionPackHelp()/printRepoDecisionHelp()and short-circuits both commands onoptions.help === true(the same patternreviewPrClialready uses, since both commands receive pre-parsedoptionsfromrunCli, not rawargs). No other behavior changed.Closes #5927
Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Closes #123) — a linked open issue is required for every contributor PR.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragelocally;codecov/patchrequires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.npm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderateIf any required check was skipped, explain why:
packages/loopover-mcp/**is outside this repo's Codecovcoverage.include(seevitest.config.ts), socodecov/patchdoes not numerically measure this change. Behavioral regression coverage is enforced instead by thetest/unit/mcp-cli-*.test.tssubprocess suite (run viatest:mcp-pack/test:ci), which now asserts both--helpinvocations print usage and exit 0 without requiring--login/--repoor making a network call.npm run test:coveragepassed the full unsharded suite except a pre-existing, unrelated failure intest/unit/selfhost-ams-reporting.test.tscaused by this local environment lacking thesqlite3binary — reproduces identically with this change stashed out.Safety
UI Evidencesection below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.Not applicable: no auth/cookie/CORS/session code was touched, and this is a CLI-only change with no UI surface.
UI Evidence
Not applicable — this is a CLI-only change (
packages/loopover-mcp/bin/loopover-mcp.js), no UI/frontend/docs surface changed.Notes
printDecisionPackHelp()/printRepoDecisionHelp()functions mirror the wording and structure of the existingprint*Helpfunctions in the same file (printReviewPrHelp,printLintPrTextHelp, etc.), including the "No source upload." / "Pass --json for machine-readable output." lines and theirUsage:line taken verbatim fromprintHelp()'s top-level usage listing.