Skip to content

fix(miner): honor --json on the discover --dry-run failure path #6051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
loopover-orb merged 1 commit into from
Jul 15, 2026
Merged

fix(miner): honor --json on the discover --dry-run failure path #6051

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/loopover-miner/lib/discover-cli.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,8 +200,7 @@ export async function runDiscover(args, options = {}) {
}
return 0;
} catch (error) {
console.error(error instanceof Error ? error.message : String(error));
return 2;
return reportCliFailure(parsed.json, describeCliError(error));
}
}

Expand Down
19 changes: 19 additions & 0 deletions test/unit/miner-discover-cli.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,6 +427,25 @@ describe("runDiscover (#4247)", () => {
expect(error).toHaveBeenCalledWith("github_unreachable");
});

it("#5830: --dry-run --json reports fan-out failures as a parseable {ok:false,error} object", async () => {
const initPortfolioQueue = vi.fn();
const fetchCandidateIssuesWithSummary = vi.fn(async () => {
throw new Error("github_unreachable");
});
const log = vi.spyOn(console, "log").mockImplementation(() => undefined);

const exitCode = await runDiscover(["acme/widgets", "--dry-run", "--json"], {
nowMs: NOW,
initPortfolioQueue,
fetchCandidateIssuesWithSummary,
});

expect(exitCode).toBe(2);
expect(initPortfolioQueue).not.toHaveBeenCalled();
const payload = JSON.parse(String(log.mock.calls[0]?.[0]));
expect(payload).toEqual({ ok: false, error: "github_unreachable" });
});

it("#4847: --dry-run stringifies a thrown non-Error value instead of crashing", async () => {
const fetchCandidateIssuesWithSummary = vi.fn(async () => {
throw "raw_string_fault";
Expand Down