Skip to content

fix(mcp): document LOOPOVER_LOGIN / GITHUB_LOGIN in loopover-mcp --help - #6052

Merged
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
jaytbarimbao-collab:fix-mcp-help-loopover-login
Jul 15, 2026
Merged

fix(mcp): document LOOPOVER_LOGIN / GITHUB_LOGIN in loopover-mcp --help#6052
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
jaytbarimbao-collab:fix-mcp-help-loopover-login

Conversation

@jaytbarimbao-collab

Copy link
Copy Markdown
Contributor

Fixes #5930.

Six subcommands (analyze-branch/preflight, review-pr, decision-pack, repo-decision, and agent plan/packet) resolve the GitHub login from options.login ?? process.env.LOOPOVER_LOGIN ?? process.env.GITHUB_LOGIN and, when missing, throw Pass --login <github-login> or set LOOPOVER_LOGIN. — but the --help Environment: block never listed LOOPOVER_LOGIN.

Adds LOOPOVER_LOGIN or GITHUB_LOGIN (with the commands it applies to) to the Environment block, plus a test asserting --help documents it. Test passes; typecheck clean.

Fixes JSONbored#5930.

Six subcommands (analyze-branch/preflight, review-pr, decision-pack,
repo-decision, and agent plan/packet) resolve the GitHub login from
`options.login ?? LOOPOVER_LOGIN ?? GITHUB_LOGIN` and error pointing at
LOOPOVER_LOGIN, but the --help Environment block never listed it. Adds it to
the block and a test asserting --help documents it.
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.22%. Comparing base (f938c75) to head (6ff2cd7).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6052       +/-   ##
===========================================
+ Coverage   32.23%   95.22%   +62.98%     
===========================================
  Files         593      593               
  Lines       46966    46972        +6     
  Branches    15010    15015        +5     
===========================================
+ Hits        15141    44730    +29589     
+ Misses      29382     1493    -27889     
+ Partials     2443      749     -1694     
Flag Coverage Δ
shard-1 44.01% <ø> (?)
shard-2 36.55% <ø> (?)
shard-3 32.15% <ø> (?)
shard-4 33.47% <ø> (?)
shard-5 31.66% <ø> (-0.58%) ⬇️
shard-6 44.36% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 476 files with indirect coverage changes

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 15, 2026
@loopover-orb

loopover-orb Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Tip

🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩

✅ LoopOver review result - approve/merge recommended

Review updated: 2026-07-15 08:04:38 UTC

2 files · 1 AI reviewer · no blockers · readiness 82/100 · CI green · clean

✅ Suggested Action - Approve/Merge

  • safe to merge

Review summary
This is a narrowly-scoped documentation fix that adds LOOPOVER_LOGIN/GITHUB_LOGIN to the --help Environment block, matching the actual resolution order (`options.login ?? process.env.LOOPOVER_LOGIN ?? process.env.GITHUB_LOGIN`) used by the six subcommands cited in the description. The accompanying test asserts the string appears in --help output, which is a real assertion against the actual code path, not a fabricated scenario. The change closes issue #5930 and is well-targeted with no scope creep.

Nits — 3 non-blocking
  • The help text line is quite long (packages/loopover-mcp/bin/loopover-mcp.js) listing all six subcommands inline — consider whether a shorter reference or wrapping matches the style of the surrounding Environment block lines.
  • The test regex `/LOOPOVER_LOGIN or GITHUB_LOGIN/` (test/unit/mcp-cli-tools.test.ts) only checks the two env var names appear together, not that the six subcommand names are actually listed — a stricter assertion could catch future regressions where the enumerated command list drifts.
  • Consider also asserting on the specific subcommand list substring in the test to guard against a future edit that keeps the env var names but silently drops or mislists one of the six commands.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ✅ Linked #5930
Related work ⚠️ 2 scoped overlaps Top overlaps are listed below; lower-confidence bulk is hidden.
Change scope ❌ 8/20 High review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 108 registered-repo PR(s), 53 merged, 4 issue(s).
Contributor context ✅ Confirmed Gittensor contributor jaytbarimbao-collab; Gittensor profile; 108 PR(s), 4 issue(s).
Gate result ✅ Passing No configured blocker found.
Improvement ✅ Minor risk: clean · value: minor · LLM: minor
Linked issue satisfaction

Addressed
The diff adds a LOOPOVER_LOGIN/GITHUB_LOGIN line to printHelp()'s Environment block in the requested style and adds a regression test asserting --help output contains it, matching both deliverables without altering resolution order or error behavior.

Review context
Contributor next steps
  • Start here: Review top overlaps.
  • Then work through the remaining 2 steps in the Signals table above.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask &lt;question&gt; answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat &lt;question&gt; answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://gittensory.aethereal.dev/docs/loopover-commands

🧪 Experimental — new and may change.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LoopOver approves — the gate is satisfied and CI is green.

@loopover-orb
loopover-orb Bot merged commit a8acb4c into JSONbored:main Jul 15, 2026
16 checks passed
@github-actions github-actions Bot mentioned this pull request Jul 15, 2026
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(mcp): loopover-mcp --help doesn't document LOOPOVER_LOGIN despite 6 commands requiring it

1 participant