fix(miner-ui): surface portfolio queue action failures to the operator - #6096
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Thread release/requeue results through runQueueAction instead of discarding them, show a role=alert error on failure, and only refresh the queue list when the action succeeds. Closes JSONbored#6090 Co-authored-by: Cursor <cursoragent@cursor.com>
|
Tip 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-15 09:21:29 UTC
✅ Suggested Action - Approve/Merge
Review summary Nits — 4 non-blocking
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://gittensory.aethereal.dev/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Summary
PortfolioQueueActionResultthroughrunQueueActioninstead of discarding it, mirroringrunGovernorActionin the ledgers route.{ok: false}action failures with the samerole=alert/ danger styling convention used elsewhere in miner-ui.{ok: true}— failed actions no longer silently re-fetch as if they succeeded.Closes #6090
Test plan
npm run ui:kit:build && npx vitest run src/portfolio-queue-actions.test.tsx(19 tests pass)