Skip to content

test: verify reviewbot unified review (throwaway) #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JSONbored wants to merge 2 commits into from
Closed

test: verify reviewbot unified review (throwaway) #630

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7889858
test: reviewbot unified-review demo (throwaway)
JSONbored Jun 12, 2026
c64b367
test: clearer findings for unified-review demo
JSONbored Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions scratch/reviewbot-unified-demo.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
// Small numeric helpers.

/** Clamp a percentage into the 0–100 range. */
export function clampPercent(value: number): number {
if (value > 100) {

@ghost ghost Jun 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue · Missing lower bound clamp

clampPercent only caps values above 100 but does not prevent negative percentages from being returned.

Suggested change
if (value > 100) {
if (value < 0) { return 0; }
🤖 Prompt for AI agents 
In scratch/reviewbot-unified-demo.ts around line 5, `clampPercent` only caps values above 100 but does not prevent negative percentages from being returned. Apply: if (value < 0) { return 0; }

return 100;
}
return value;
}

/** Return the average of the numbers. */
export function average(values: number[]): number {
return values.reduce((a, b) => a + b, 0) / values.length;

@ghost ghost Jun 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue · Division by zero on empty array

average divides by values.length without checking for an empty array, yielding NaN.

Suggested change
return values.reduce((a, b) => a + b, 0) / values.length;
if (values.length === 0) { return 0; }
🤖 Prompt for AI agents 
In scratch/reviewbot-unified-demo.ts around line 13, `average` divides by `values.length` without checking for an empty array, yielding NaN. Apply: if (values.length === 0) { return 0; }

}

/** Parse a port number from a string, defaulting to 8080. */
export function parsePort(raw: string): number {
return parseInt(raw) || 8080;

@ghost ghost Jun 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick · Port validation

parsePort returns any numeric value, including negatives or >65535, which are invalid ports.

Suggested change
return parseInt(raw) || 8080;
const port = parseInt(raw); return (port > 0 && port <= 65535) ? port : 8080;
🤖 Prompt for AI agents 
In scratch/reviewbot-unified-demo.ts around line 18, `parsePort` returns any numeric value, including negatives or >65535, which are invalid ports. Apply: const port = parseInt(raw); return (port > 0 && port <= 65535) ? port : 8080;

}