Skip to content

docs(ams): port docs/config-precedence.md to a website docs page (docs.ams-config-precedence.tsx) - #6360

Merged
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
oktofeesh1:docs/ams-config-precedence-6027
Jul 16, 2026
Merged

docs(ams): port docs/config-precedence.md to a website docs page (docs.ams-config-precedence.tsx)#6360
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
oktofeesh1:docs/ams-config-precedence-6027

Conversation

@oktofeesh1

Copy link
Copy Markdown
Contributor

Summary

  • Adds content/docs/ams-config-precedence.mdx porting packages/loopover-miner/docs/config-precedence.md to the website: AMS's per-concern configuration layering (per-repo goal spec, operator env, CLI flags, operator policy file) for the kill switch, governor live mode, coding-agent execution mode, forge credential resolution, GitHub token resolution, and local store paths — rendered via the existing DocsPage/Callout/CodeBlock/FeatureRow ui-kit primitives, following the pattern set in docs(ams): port DEPLOYMENT.md to a website docs page (docs.ams-deployment.tsx) #6022-docs(ams): port docs/sizing.md to a website docs page (docs.ams-sizing.tsx) #6026.
  • Adds apps/loopover-ui/src/routes/docs.ams-config-precedence.tsx, a thin loader + docsClientLoader route matching every other migrated docs page.
  • Adds the page to docs-nav.tsx's "AMS: deployment" subgroup and to docs.index.tsx's Maintainers audience card.
  • The numbered "Order" lists (which don't contain nested code blocks) are converted to bold-paragraph format, matching the source's own numbering; the layers/discovery tables that are genuinely tabular data are presented as FeatureRow items (no table mapping is registered in docs-mdx-components.tsx).
  • packages/loopover-miner/docs/config-precedence.md stays as the canonical source: it ships inside the published @loopover/miner npm package. A short pointer to the new website page was added at the top.

Scope

Validation

  • git diff --check
  • npm run actionlint
  • npm run typecheck
  • npm run test:coverage locally — UI-only page addition under apps/loopover-ui/** (outside coverage.include); codecov/patch does not apply
  • npm run test:workers
  • npm run build:mcp
  • npm run test:mcp-pack
  • npm run ui:openapi:check
  • npm run ui:lint
  • npm run ui:typecheck
  • npm run ui:build
  • npm audit --audit-level=moderate
  • Full npm run test:ci run locally from a clean npm ci install, green — 0 real FAIL markers
  • npm run ui:build run explicitly during authoring to catch any MDX parse issues before the full gate, given a prior sub-issue PR (docs(ams): port docs/sizing.md to a website docs page (docs.ams-sizing.tsx) #6026) hit a real MDX parse bug this way

Safety

  • No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
  • Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
  • Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests. — N/A, no such changes in this PR
  • API/OpenAPI/MCP behavior is updated and tested where needed. — N/A, no API/OpenAPI/MCP behavior changed
  • UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks. — N/A, static docs content only
  • Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs.

Notes

…s.ams-config-precedence.tsx)

Add content/docs/ams-config-precedence.mdx covering AMS's per-concern
configuration layering (per-repo goal spec, operator env, CLI flags,
operator policy file) for kill switch, governor live mode, coding-agent
execution mode, forge credential resolution, GitHub token resolution, and
local store paths -- rendered via the existing DocsPage/Callout/CodeBlock/
FeatureRow primitives. Add the page to docs-nav.tsx's "AMS: deployment"
subgroup and to docs.index.tsx's Maintainers audience card.

packages/loopover-miner/docs/config-precedence.md stays as the canonical
source (ships inside the published @loopover/miner package) with a short
pointer added to the new website page.
@oktofeesh1
oktofeesh1 requested a review from JSONbored as a code owner July 16, 2026 04:21
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@loopover-orb loopover-orb Bot added the gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. label Jul 16, 2026
@loopover-orb

loopover-orb Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Tip

✅ LoopOver review result - approve/merge recommended

Review updated: 2026-07-16 04:26:38 UTC

6 files · 1 AI reviewer · no blockers · readiness 82/100 · CI green · clean

✅ Suggested Action - Approve/Merge

  • safe to merge

Review summary
This is a straightforward docs-porting PR that adds a new website docs page (ams-config-precedence.mdx) mirroring the existing packages/loopover-miner/docs/config-precedence.md, wires it into the route tree, docs-nav, and docs.index audience card, and leaves a pointer comment in the canonical markdown source. The route file follows the exact established pattern from prior migrated pages (#6022-#6026), the routeTree.gen.ts diff is generated and internally consistent (import, route definition, all four FileRoutesBy* maps, children interface), and the nav/index additions are single-line insertions matching existing entries. Content conversion choices (numbered lists to bold paragraphs, tables to FeatureRow) are reasonable given no table mapping exists in docs-mdx-components.tsx, and the PR closes issue #6027 as required.

Nits — 5 non-blocking
  • The og:description and meta description in docs.ams-config-precedence.tsx:16-24 are duplicated verbatim rather than reused from a shared constant, unlike title/description which come from loader data — minor duplication but consistent with the pattern in sibling docs routes.
  • No automated test verifies the new route resolves or that docs-nav/docs.index links point to a valid page, though this matches the zero-test-path convention of prior sibling docs-page PRs in this series.
  • Consider extracting the repeated description string in docs.ams-config-precedence.tsx into a single constant to avoid the meta/og drift risk if one is edited without the other.
  • Double check content/docs/ams-config-precedence.mdx renders correctly through docsClientLoader in a local dev run, since MDX authoring errors (e.g. malformed FeatureRow items) are not caught by typecheck alone.
  • Code changes lack test evidence — Add focused regression tests or explain why existing coverage is sufficient.

Decision drivers

  • ✅ Code review — No blockers (1 reviewer)
  • ✅ Gate result — Passing (No configured blocker found.)
Context & advisory signals — never blocks the verdict
Signal Result Evidence
Linked issue ✅ Linked #6027
Related work ⚠️ 3 scoped overlaps Top overlaps are listed below; lower-confidence bulk is hidden.
Change scope ❌ 8/20 High review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 63 registered-repo PR(s), 51 merged, 0 issue(s).
Contributor context ✅ Confirmed Gittensor contributor oktofeesh1; Gittensor profile; 63 PR(s), 0 issue(s).
Improvement ℹ️ None detected risk: low · value: none · LLM: minor
Linked issue satisfaction

Not yet addressed
The issue's callout explicitly states that a PR is not resolved if it leaves docs/config-precedence.md's content unchanged while only linking to it, or if it adds an .md file as the deliverable — this PR does exactly that, keeping the .md file fully intact (only adding a pointer) and routing the actual content through a new content/docs/ams-config-precedence.mdx file rather than porting it directl

Review context
  • Author: oktofeesh1
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: not available
  • Official Gittensor activity: 63 PR(s), 0 issue(s).
  • Related work: Titles/paths share 12 meaningful terms. (issue #6031, issue #6027)
  • Related work: Titles/paths share 12 meaningful terms. (issue #6031, issue #6030)
  • Related work: Titles/paths share 12 meaningful terms. (issue #6031, issue #6028)
  • Additional title-only matches omitted; title-only overlap does not block.
Contributor next steps
  • Start here: Review top overlaps.
  • Then work through the remaining 2 steps in the Signals table above.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://gittensory.aethereal.dev/docs/loopover-commands

🧪 Experimental — new and may change.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LoopOver approves — the gate is satisfied and CI is green.

@loopover-orb
loopover-orb Bot merged commit b7e1bec into JSONbored:main Jul 16, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs(ams): port docs/config-precedence.md to a website docs page (docs.ams-config-precedence.tsx)

1 participant