fix(mcp): print unknown API compatibility in status (#6263) - #6363
Conversation
…nimum version Add handling for the "unknown" API compatibility status in the loopover-mcp CLI, ensuring that an unparseable minimum version is reported in human-readable output. Update unit tests to verify this behavior, confirming that the output includes the unsupported minimum client version when applicable.
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6363 +/- ##
=======================================
Coverage 95.60% 95.60%
=======================================
Files 597 597
Lines 47191 47191
Branches 15019 15019
=======================================
Hits 45117 45117
Misses 1290 1290
Partials 784 784
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Tip ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-16 05:28:07 UTC
Review summary Nits — 4 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Summary
loopover-mcp statusnow covers theapi_compatibilityunknowncase (unparseable minimum version), matchingdoctor()'s warning instead of omitting compatibility entirely.minMcpVersionand asserts both JSON and human status output report it.Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Closes #123) — a linked open issue is required for every contributor PR.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragelocally;codecov/patchrequires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.npm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderateIf any required check was skipped, explain why:
npx vitest run test/unit/mcp-cli-doctor.test.ts(19/19 passed), including the new#6263regression. Fullnpm run test:cinot run yet on this Windows checkout (platform-forcednpm ci --force); run the full gate before push.Safety
UI Evidencesection below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.UI Evidence
N/A — CLI-only change.
Notes
doctor()was left unchanged; onlystatus()'s human-readable branch gained the missingunknownarm.