fix(ci): derive version-copy floor from single source of truth - #6374
Merged
Conversation
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6374 +/- ##
=======================================
Coverage 95.60% 95.60%
=======================================
Files 599 601 +2
Lines 47301 47310 +9
Branches 15046 15050 +4
=======================================
+ Hits 45223 45232 +9
Misses 1291 1291
Partials 787 787
Flags with carried forward coverage won't be shown. Click here to find out more. |
nghetienhiep
force-pushed
the
fix/issue-6292
branch
from
July 16, 2026 05:18
9832b50 to
b49cf4c
Compare
nghetienhiep
force-pushed
the
fix/issue-6292
branch
2 times, most recently
from
July 16, 2026 05:27
9e98527 to
9467e57
Compare
nghetienhiep
force-pushed
the
fix/issue-6292
branch
2 times, most recently
from
July 16, 2026 05:41
a3025bd to
7676b81
Compare
nghetienhiep
force-pushed
the
fix/issue-6292
branch
from
July 16, 2026 05:47
7676b81 to
35b89c7
Compare
nghetienhiep
force-pushed
the
fix/issue-6292
branch
from
July 16, 2026 05:50
35b89c7 to
639e3fe
Compare
nghetienhiep
force-pushed
the
fix/issue-6292
branch
3 times, most recently
from
July 16, 2026 06:09
0e491c8 to
e36dfcf
Compare
nghetienhiep
force-pushed
the
fix/issue-6292
branch
2 times, most recently
from
July 16, 2026 06:16
1307d60 to
77d9ed0
Compare
nghetienhiep
force-pushed
the
fix/issue-6292
branch
4 times, most recently
from
July 16, 2026 06:23
ea2fdc8 to
bf0d847
Compare
nghetienhiep
force-pushed
the
fix/issue-6292
branch
from
July 16, 2026 06:34
bf0d847 to
1c4f7a5
Compare
nghetienhiep
force-pushed
the
fix/issue-6292
branch
3 times, most recently
from
July 16, 2026 06:41
2300789 to
c87b1fb
Compare
The deterministic half of check-ui-mcp-version-copy.mjs hardcoded v0.2 / 0.2.x / 0.2.0 as the stale-version and minimum-supported-floor literals. The real floor has since moved to 0.5.0 (MCP_MINIMUM_SUPPORTED_VERSION), so the text scan was aimed several majors out of date and could no longer catch current drift — its only live defense was the best-effort npm-registry diff. Read the floor from MCP_MINIMUM_SUPPORTED_VERSION in apps/loopover-ui/src/lib/mcp-package.ts (the same module the known-latest check already reads) and build the three stale-version matchers from it, so a future floor bump can't silently leave this check frozen again. This surfaces the stale 0.5.0 examples in packages/loopover-mcp/README.md, which are updated to the current 3.0.0 package version. Adds a unit test asserting the script reads the floor dynamically from the shipped constant and that the matchers flag the stale forms while leaving the current version and the explicit minimum-supported line alone. Closes JSONbored#6292
nghetienhiep
force-pushed
the
fix/issue-6292
branch
from
July 16, 2026 06:46
c87b1fb to
ab11e8b
Compare
JSONbored
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(ci): derive version-copy floor from single source of truth
The deterministic half of check-ui-mcp-version-copy.mjs hardcoded v0.2 /
0.2.x / 0.2.0 as the stale-version and minimum-supported-floor literals. The
real floor has since moved to 0.5.0 (MCP_MINIMUM_SUPPORTED_VERSION), so the
text scan was aimed several majors out of date and could no longer catch
current drift — its only live defense was the best-effort npm-registry diff.
Read the floor from MCP_MINIMUM_SUPPORTED_VERSION in
apps/loopover-ui/src/lib/mcp-package.ts (the same module the known-latest
check already reads) and build the three stale-version matchers from it, so a
future floor bump can't silently leave this check frozen again. This surfaces
the stale 0.5.0 examples in packages/loopover-mcp/README.md, which are updated
to the current 3.0.0 package version.
Adds a unit test asserting the script reads the floor dynamically from the
shipped constant and that the matchers flag the stale forms while leaving the
current version and the explicit minimum-supported line alone.
Closes #6292