Skip to content

docs(ams): port docs/miner-goal-spec.md to a website docs page (docs.ams-goal-spec.tsx) - #6397

Merged
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
oktofeesh1:docs/ams-goal-spec-6030
Jul 16, 2026
Merged

docs(ams): port docs/miner-goal-spec.md to a website docs page (docs.ams-goal-spec.tsx)#6397
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
oktofeesh1:docs/ams-goal-spec-6030

Conversation

@oktofeesh1

Copy link
Copy Markdown
Contributor

Summary

  • Adds content/docs/ams-goal-spec.mdx porting packages/loopover-miner/docs/miner-goal-spec.md to the website: every MinerGoalSpec field (.loopover-miner.yml) — minerEnabled, wantedPaths/blockedPaths, preferredLabels/blockedLabels, maxConcurrentClaims, issueDiscoveryPolicy, feasibilityGate, selfPlagiarism, killSwitch, and execution — and its relationship to .loopover.yml, rendered via the existing DocsPage/Callout/FeatureRow ui-kit primitives, following the pattern set in docs(ams): port DEPLOYMENT.md to a website docs page (docs.ams-deployment.tsx) #6022-docs(ams): port docs/discovery-plane-operator-guide.md to a website docs page (docs.ams-discovery-plane.tsx) #6029.
  • Adds apps/loopover-ui/src/routes/docs.ams-goal-spec.tsx, a thin loader + docsClientLoader route matching every other migrated docs page.
  • Adds the page to docs-nav.tsx's "AMS: deployment" subgroup and to docs.index.tsx's Maintainers audience card, and repoints ams-deployment.mdx's and ams-config-precedence.mdx's GitHub-blob miner-goal-spec.md cross-references to the new in-app route.
  • packages/loopover-miner/docs/miner-goal-spec.md stays as the canonical source: it ships inside the published @loopover/miner npm package and its content is directly asserted by miner-goal-spec-doc.test.ts. A short pointer to the new website page was added at the top.

Scope

Validation

  • git diff --check
  • npm run actionlint
  • npm run typecheck
  • npm run test:coverage locally — UI-only page addition under apps/loopover-ui/** (outside coverage.include); codecov/patch does not apply
  • npm run test:workers
  • npm run build:mcp
  • npm run test:mcp-pack
  • npm run ui:openapi:check
  • npm run ui:lint
  • npm run ui:typecheck
  • npm run ui:build
  • npm audit --audit-level=moderate
  • Full npm run test:ci run locally from a clean npm ci install, green: 908 test files / 17,352 tests passed
  • Targeted re-run of miner-goal-spec-doc.test.ts — passes unchanged

Safety

  • No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
  • Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
  • Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests. — N/A, no such changes in this PR
  • API/OpenAPI/MCP behavior is updated and tested where needed. — N/A, no API/OpenAPI/MCP behavior changed
  • UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks. — N/A, static docs content only
  • Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs.

Notes

@oktofeesh1
oktofeesh1 requested a review from JSONbored as a code owner July 16, 2026 06:26
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

…ams-goal-spec.tsx)

Add content/docs/ams-goal-spec.mdx covering every MinerGoalSpec field
(.loopover-miner.yml) -- minerEnabled, wantedPaths/blockedPaths,
preferredLabels/blockedLabels, maxConcurrentClaims, issueDiscoveryPolicy,
feasibilityGate, selfPlagiarism, killSwitch, and execution -- and its
relationship to .loopover.yml, rendered via the existing DocsPage/Callout/
FeatureRow primitives. Add the page to docs-nav.tsx's "AMS: deployment"
subgroup and to docs.index.tsx's Maintainers audience card, and repoint
ams-deployment.mdx's and ams-config-precedence.mdx's GitHub-blob
miner-goal-spec.md cross-references to the new in-app route.

packages/loopover-miner/docs/miner-goal-spec.md stays as the canonical
source (ships inside the published @loopover/miner package; its content is
directly asserted by miner-goal-spec-doc.test.ts) with a short pointer added
to the new website page.
@oktofeesh1
oktofeesh1 force-pushed the docs/ams-goal-spec-6030 branch from d307e94 to 6076b12 Compare July 16, 2026 06:32
@loopover-orb loopover-orb Bot added the gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. label Jul 16, 2026
@loopover-orb

loopover-orb Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Tip

✅ LoopOver review result - approve/merge recommended

Review updated: 2026-07-16 06:44:58 UTC

8 files · 1 AI reviewer · no blockers · readiness 77/100 · CI green · clean

✅ Suggested Action - Approve/Merge

  • safe to merge

Review summary
This is a straightforward docs port following the established pattern from PRs #6022-#6029: a new MDX content file, a matching thin route (loader + docsClientLoader), routeTree.gen.ts codegen updates, and nav/cross-reference wiring in two already-migrated pages. The route and component follow the exact same shape as sibling docs routes, the canonical markdown source is preserved with a pointer added, and cross-references in ams-config-precedence.mdx and ams-deployment.mdx are correctly repointed from GitHub blob links to the new in-app route. routeTree.gen.ts is generated output consistent with the new route file, so it's expected churn rather than a maintainability concern.

Nits — 4 non-blocking
  • No test coverage is added for the new route (apps/loopover-ui/src/routes/docs.ams-goal-spec.tsx), though this matches the pattern of prior docs-page PRs in this series which also ship without route-level tests.
  • The 'flagged for `any`' cast at routeTree.gen.ts:366 is inside generated code and not something a contributor should hand-edit — no action needed here.
  • If the project has any lint/CI step that validates docs-nav entries against routeTree.gen.ts routes (broken-link check), confirm it passes for `/docs/ams-goal-spec` since it's not visible in this diff context.
  • Code changes lack test evidence — Add focused regression tests or explain why existing coverage is sufficient.

Decision drivers

  • ✅ Code review — No blockers (1 reviewer)
  • ✅ Gate result — Passing (No configured blocker found.)
Context & advisory signals — never blocks the verdict
Signal Result Evidence
Linked issue ✅ Linked #6030
Related work ⚠️ 3 scoped overlaps Top overlaps are listed below; lower-confidence bulk is hidden.
Change scope ❌ 8/20 High review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 66 registered-repo PR(s), 54 merged, 0 issue(s).
Contributor context ✅ Confirmed Gittensor contributor oktofeesh1; Gittensor profile; 66 PR(s), 0 issue(s).
Improvement ℹ️ None detected risk: low · value: none · LLM: minor
Linked issue satisfaction

Partially addressed
The PR delivers the required docs.ams-goal-spec.tsx route, ports the full field reference content, and wires it into docs-nav.tsx and docs.index.tsx as required, but it explicitly keeps miner-goal-spec.md's substantive content in place (only prepending a pointer note) rather than deleting it or reducing it to a one-line pointer stub as the issue mandates once the .tsx ships.

Review context
  • Author: oktofeesh1
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: not available
  • Official Gittensor activity: 66 PR(s), 0 issue(s).
  • Related work: Titles/paths share 6 meaningful terms. (issue #6031)
  • Related work: Titles/paths share 12 meaningful terms. (issue #6030, issue #6031)
  • Related work: Titles/paths share 11 meaningful terms. (issue #6030, issue #6032)
  • Additional title-only matches omitted; title-only overlap does not block.
Contributor next steps
  • Start here: Review top overlaps.
  • Then work through the remaining 3 steps in the Signals table above.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

Visual preview
Route Viewport Before (production) After (this PR's preview) Diff
/docs/ams-goal-spec desktop before /docs/ams-goal-spec
before /docs/ams-goal-spec
after /docs/ams-goal-spec
after /docs/ams-goal-spec
/docs/ams-goal-spec mobile before /docs/ams-goal-spec (mobile)
before /docs/ams-goal-spec (mobile)
after /docs/ams-goal-spec (mobile)
after /docs/ams-goal-spec (mobile)
/docs desktop before /docs
before /docs
after /docs
after /docs
/docs mobile before /docs (mobile)
before /docs (mobile)
after /docs (mobile)
after /docs (mobile)

Click any thumbnail to open the full-size screenshot. Before = production · After = this PR's preview deploy.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LoopOver approves — the gate is satisfied and CI is green.

@loopover-orb
loopover-orb Bot merged commit af2583c into JSONbored:main Jul 16, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs(ams): port docs/miner-goal-spec.md to a website docs page (docs.ams-goal-spec.tsx)

1 participant