Skip to content

chore(ui): remove dead Breadcrumbs and ScrollFlow components - #6450

Merged
JSONbored merged 1 commit into
JSONbored:mainfrom
luciferlive112116:chore/ui-remove-dead-components
Jul 16, 2026
Merged

chore(ui): remove dead Breadcrumbs and ScrollFlow components#6450
JSONbored merged 1 commit into
JSONbored:mainfrom
luciferlive112116:chore/ui-remove-dead-components

Conversation

@luciferlive112116

Copy link
Copy Markdown
Contributor

Summary

components/site/breadcrumbs.tsx and components/site/scroll-flow.tsx are fully implemented but have zero import sites anywhere in apps/loopover-ui/src. This removes both.

Verified dead, not assumed

I searched the whole repo for Breadcrumbs, ScrollFlow, and their exported Crumb / FlowStep types before deleting:

  • The only hits are the two definitions themselves. Every other match is Sentry's own error-breadcrumbs concept (src/selfhost/sentry.ts, apps/loopover-ui/src/lib/browser-sentry.ts) — an unrelated use of the word.
  • No import statement references components/site/breadcrumbs or components/site/scroll-flow anywhere in apps/, src/, or test/.
  • No dedicated test file, no barrel/index re-export, no reference in routeTree.gen.ts or any docs content.

breadcrumbs.tsx's own doc comment claims it is the "breadcrumb rail used on /app, /docs, /api headers." The issue flagged this as the thing to check before deleting — so I checked: none of those pages import it. The component was written and never wired in, and no page renders a breadcrumb rail today, so there is no genuine gap to wire it into rather than delete. components/ui/breadcrumb.tsx is a separate shadcn primitive (different path, singular) and is untouched.

Why this is safe

  • Nothing depends on either file, so removing them changes no other module — and no page's rendered output changes (they were never rendered).
  • Deleting them also clears two react-refresh/only-export-components warnings: each file exported an interface (Crumb / FlowStep) alongside its component.

Validation

  • npm run ui:typecheck — clean (both @loopover/ui and @loopover/ui-miner). Nothing references the deleted symbols.
  • npm run ui:build — clean: 121 modules transformed, neither file was in the build graph.
  • npm run ui:lint — introduces no new violation. The only errors are the repo-wide CRLF prettier/prettier noise from a Windows checkout (0 non-prettier errors), which is absent on CI's LF checkout; my change is a pure deletion and cannot add a lint error to a surviving file.
  • Confirmed no generated artifact (routeTree.gen.ts, openapi.json) references the components; the working tree contains only the two deletions.
  • Rebased on latest main — no base conflict.

Coverage

No patch surface: apps/** is in Codecov's ignore list, and this is a deletion regardless.

Scope

  • Two file deletions, one coherent change, in a wanted path (apps/loopover-ui/). Maintainer-authored issue, so this is approved maintenance rather than speculative cosmetic churn.
  • No visible UI change — the components were never rendered, so there is nothing to screenshot.
  • No secrets; no changelog, site/, CNAME, or lovable changes.

Safety

  • Pure removal of unreferenced code; no behaviour change for any page that ships today.

Closes #6182

Both components under components/site/ are fully implemented but have zero
import sites anywhere in apps/loopover-ui/src. A repo-wide search for
`Breadcrumbs`, `ScrollFlow`, and their `Crumb`/`FlowStep` types finds only
the definitions themselves; the other hits are Sentry's own error
"breadcrumbs" (src/selfhost/sentry.ts, browser-sentry.ts), an unrelated
concept. Neither has a dedicated test, a barrel re-export, or a reference
in a generated file or docs page.

breadcrumbs.tsx's doc comment claims it is the "breadcrumb rail used on
/app, /docs, /api headers", but none of those pages import it -- the
component was written and never wired in. Per the issue, this was the point
to check before deleting: no current page renders a breadcrumb rail today,
so there is no genuine gap to wire it into. components/ui/breadcrumb.tsx is
a separate shadcn primitive and is untouched.

Removing both drops nothing anything else depends on. It also clears two
react-refresh/only-export-components warnings, since each file exported an
interface (Crumb / FlowStep) alongside its component.

Verified: ui:typecheck clean, ui:build clean (121 modules, neither file was
in the graph), and ui:lint gains no new violation (the only errors are the
repo-wide CRLF prettier noise, absent on CI's LF checkout).

Closes JSONbored#6182
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 16, 2026
@loopover-orb

loopover-orb Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Tip

✅ LoopOver review result - approve/merge recommended

Review updated: 2026-07-16 08:45:28 UTC

2 files · 1 AI reviewer · no blockers · readiness 100/100 · CI green · clean

✅ Suggested Action - Approve/Merge

  • safe to merge

Review summary
This PR deletes two fully-unused UI components (breadcrumbs.tsx, scroll-flow.tsx) after a documented search confirming zero import sites across the repo, distinguishing them from the similarly-named but distinct components/ui/breadcrumb.tsx primitive. The diff is a clean pure deletion with no other files touched, CI passed including typecheck and build, and the PR links issue #6182 which explicitly calls for removing these two dead components.

Nits — 3 non-blocking
  • No test-path changes are expected here since this is a pure deletion of dead code with no behavior to test — nothing further to add.
  • Consider a follow-up grep-based CI check or lint rule to catch unused exported components automatically so future dead code doesn't accumulate.
  • Code changes lack test evidence — Add focused regression tests or explain why existing coverage is sufficient.

Decision drivers

  • ✅ Code review — No blockers (1 reviewer)
  • ✅ Gate result — Passing (No configured blocker found.)
Context & advisory signals — never blocks the verdict
Signal Result Evidence
Linked issue ✅ Linked #6182
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 149 registered-repo PR(s), 88 merged, 31 issue(s).
Contributor context ✅ Confirmed Gittensor contributor luciferlive112116; Gittensor profile; 149 PR(s), 31 issue(s).
Improvement ℹ️ None detected risk: low · value: none
Review context
  • Author: luciferlive112116
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: Python, JavaScript, MDX, Rust, TypeScript
  • Official Gittensor activity: 149 PR(s), 31 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Keep the PR focused and include validation evidence before maintainer review.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

Visual preview
Route Viewport Before (production) After (this PR's preview) Diff
/ desktop before /
before /
after /
after /
diff /
diff /
/ mobile before / (mobile)
before / (mobile)
after / (mobile)
after / (mobile)
diff / (mobile)
diff / (mobile)

Click any thumbnail to open the full-size screenshot. Before = production · After = this PR's preview deploy · Diff highlights exactly what changed.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@loopover-orb loopover-orb Bot added the manual-review Gittensor contributor context label Jul 16, 2026
@JSONbored
JSONbored merged commit adfc00c into JSONbored:main Jul 16, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. manual-review Gittensor contributor context

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(ui): remove 2 dead components (Breadcrumbs, ScrollFlow) with zero real import sites

2 participants