fix(review): thread commitMessages to the live slop gate, wire screenshot-gate advisory mode, and scope rate limits per-repo - #6457
Merged
Conversation
…imit scope - Fetch the PR's own commit messages via a new listPullRequestCommitMessages helper and thread them into the live gate's buildSlopAssessment call, so low_quality_commit_message (weight 15) can actually fire in production instead of unconditionally short-circuiting on undefined commitMessages. - Screenshot-table gate: action: "advisory" previously discarded a violation entirely (only "close" produced any signal). Add maybeAddScreenshotTableAdvisoryFinding, mirroring the lockfile-tamper-risk advisory pattern, so an advisory-mode violation appends a visible, non-blocking finding instead of silently doing nothing. - Scope commandRateLimitPolicy's per-command counter and the intent-routing classifier's counter to (actor, command, repo) instead of (actor, command, repo#issueNumber), mirroring the #4021 fix already applied to review-nag's cooldown. Opening a fresh issue/PR no longer resets an actor's AI-cost-bearing command budget.
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6457 +/- ##
==========================================
- Coverage 95.59% 95.58% -0.01%
==========================================
Files 589 589
Lines 47025 47047 +22
Branches 14951 14957 +6
==========================================
+ Hits 44952 44969 +17
- Misses 1291 1293 +2
- Partials 782 785 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 3 confirmed adversarial-audit finding(s) in
src/queue/processors.ts:src/queue/processors.ts)src/queue/processors.ts)src/queue/processors.ts)Each fix follows the audit's own verified failure scenario and root-cause analysis (2-independent-skeptic adversarial verification pass, both had to vote "confirmed").
Closes #6408
Closes #6409
Closes #6412
Test plan
npm run test:ci) green