Skip to content

fix(public-stats): rename the live GitHub-stats allowlist/proxy to the current repo - #6498

Closed
JSONbored wants to merge 2 commits into
mainfrom
fix/public-repo-stats-allowlist-rename
Closed

fix(public-stats): rename the live GitHub-stats allowlist/proxy to the current repo#6498
JSONbored wants to merge 2 commits into
mainfrom
fix/public-repo-stats-allowlist-rename

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Summary

  • wrangler.jsonc's PUBLIC_REPO_STATS_ALLOWLIST (gates the live GET /v1/public/github/repos/:owner/:repo/stats proxy, src/github/public.ts) and github-stats-chip.tsx's own fetch/fallback URL both still targeted JSONbored/gittensory — worked only via GitHub's repo-rename redirect. Points both at JSONbored/loopover directly, and updates its test + sessionStorage cache key to match.
  • LOOPOVER_DRIFT_ISSUE_REPO is also updated to JSONbored/loopover for the same reason (currently dormant — LOOPOVER_AUTO_FILE_DRIFT_ISSUES is off — but would otherwise file drift issues against the wrong repo the moment that flag is enabled).
  • Deliberately does not touch LOOPOVER_PUBLIC_STATS_REPOS, which is a separate, correctly old-name-keyed allowlist for this repo's own HISTORICAL audit_events ledger data (see its own doc comment in wrangler.jsonc) — renaming it would point the historical stats query at a repo_full_name with zero matching rows.

Part of a broader gittensory→loopover residue cleanup (see sibling PRs).

Note: wrangler.jsonc vars require a wrangler deploy after merge to take effect in production.

Validation

  • npx wrangler deploy --dry-run (config parses, values confirmed)
  • github-stats-chip.test.tsx green

@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.56%. Comparing base (2bc5481) to head (2d3e184).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6498   +/-   ##
=======================================
  Coverage   95.56%   95.56%           
=======================================
  Files         589      589           
  Lines       47121    47121           
  Branches    14989    14989           
=======================================
  Hits        45032    45032           
  Misses       1297     1297           
  Partials      792      792           
Flag Coverage Δ
shard-1 43.89% <ø> (-0.19%) ⬇️
shard-2 37.10% <ø> (+0.39%) ⬆️
shard-3 32.31% <ø> (-0.04%) ⬇️
shard-4 34.41% <ø> (-0.83%) ⬇️
shard-5 31.40% <ø> (+0.42%) ⬆️
shard-6 45.66% <ø> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 16, 2026
@loopover-orb

loopover-orb Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Caution

🛑 LoopOver review result - fixes required

Review updated: 2026-07-16 12:57:02 UTC

3 files · 1 AI reviewer · 1 blocker · CI failing · blocked

🛑 Suggested Action - Manual Review

Review summary
This PR consistently renames the live GitHub-stats allowlist, proxy target, and cache key from the old jsonbored/gittensory identity to jsonbored/loopover across the chip component, its test, and wrangler.jsonc's PUBLIC_REPO_STATS_ALLOWLIST and LOOPOVER_DRIFT_ISSUE_REPO vars, while correctly leaving LOOPOVER_PUBLIC_STATS_REPOS untouched per its documented historical-ledger rationale. The change is small, coherent, and every renamed string has a matching consumer (src/github/public.ts's allowlist check, the chip's fetch/fallback/cache-key, and the test's expected fallback URL), so the rename is not merely cosmetic — it removes a redirect-dependent path. The only operational caveat, already called out in the description, is that wrangler.jsonc vars require a redeploy to take effect.

Nits — 4 non-blocking
  • The PR description notes CI validation (`wrangler deploy --dry-run`, test green) but the actual CI run shows validate-code/validate/validate-tests (2,5,6) failing — worth confirming those failures are unrelated pre-existing issues and not caused by this diff.
  • wrangler.jsonc:203 comment above LOOPOVER_PUBLIC_STATS_REPOS could be updated to explicitly cross-reference this PR's rationale for leaving it gittensory-keyed, for future readers who only see the allowlist line change nearby.
  • Consider a quick grep across the repo for any other lingering `jsonbored/gittensory` (case-insensitive) references tied to the live proxy path to ensure this rename is complete in one pass.
  • Code changes lack test evidence — Add focused regression tests or explain why existing coverage is sufficient.

Why this is blocked

  • No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.
📋 Copy for AI agents — paste into your coding agent
Fix the following blocker(s) from this PR review:

1. No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.

CI checks failing

  • validate
  • validate-code

Decision drivers

  • ❌ Code review — 1 blocker (1 reviewer)
  • ❌ Gate result — Blocking (Repo-configured hard blocker found.)
Context & advisory signals — never blocks the verdict
Signal Result Evidence
Linked issue ✅ No-issue rationale PR body explains why no issue is linked.
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (no linked issue context).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 33 registered-repo PR(s), 26 merged, 311 issue(s).
Contributor context ✅ Confirmed Gittensor contributor JSONbored; Gittensor profile; 33 PR(s), 311 issue(s).
Improvement ℹ️ None detected risk: low · value: none
Review context
  • Author: JSONbored
  • Role context: owner (maintainer lane)
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: not available
  • Official Gittensor activity: 33 PR(s), 311 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Start here: Treat this as maintainer-lane context rather than normal contributor-lane activity.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask &lt;question&gt; answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat &lt;question&gt; answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

Visual preview
Route Viewport Before (production) After (this PR's preview) Diff
/ desktop before /
before /
after /
after /
diff /
diff /
/ mobile before / (mobile)
before / (mobile)
after / (mobile)
after / (mobile)

Click any thumbnail to open the full-size screenshot. Before = production · After = this PR's preview deploy · Diff highlights exactly what changed.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@loopover-orb loopover-orb Bot added the manual-review Gittensor contributor context label Jul 16, 2026
…e current repo

wrangler.jsonc's PUBLIC_REPO_STATS_ALLOWLIST (gates the live GET /v1/public/github/
repos/:owner/:repo/stats proxy, src/github/public.ts) and github-stats-chip.tsx's own
fetch/fallback URL both still targeted "JSONbored/gittensory" -- worked only via
GitHub's repo-rename redirect. Points both at JSONbored/loopover directly, and updates
its test + sessionStorage cache key to match.

LOOPOVER_DRIFT_ISSUE_REPO is also updated to JSONbored/loopover for the same reason
(currently dormant, LOOPOVER_AUTO_FILE_DRIFT_ISSUES is off, but would otherwise file
drift issues against the wrong repo the moment that flag is enabled).

Deliberately does NOT touch LOOPOVER_PUBLIC_STATS_REPOS, which is a separate, correctly
old-name-keyed allowlist for this repo's own HISTORICAL audit_events ledger data (see
its own doc comment in wrangler.jsonc) -- renaming it would point the historical stats
query at a repo_full_name with zero matching rows.
…list rename

wrangler.jsonc's LOOPOVER_DRIFT_ISSUE_REPO and PUBLIC_REPO_STATS_ALLOWLIST
vars moved to JSONbored/loopover but the committed generated types weren't
regenerated, tripping the cf-typegen drift check in CI.
@JSONbored

Copy link
Copy Markdown
Owner Author

Closing as superseded — every change here (wrangler.jsonc's LOOPOVER_DRIFT_ISSUE_REPO/PUBLIC_REPO_STATS_ALLOWLIST vars, and the GitHub-stats-chip repo string) already landed on main via #6532. Rebasing this branch confirms it: the wrangler.jsonc commit drops as an empty patch, and the only remaining conflict is in the generated worker-configuration.d.ts, which regenerates identically to what's already on main.

@JSONbored JSONbored closed this Jul 16, 2026
@JSONbored
JSONbored deleted the fix/public-repo-stats-allowlist-rename branch July 19, 2026 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. manual-review Gittensor contributor context

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant