refactor(test): move queue.test.ts/queue-5.test.ts's Batch A fields to manifest injection - #6533
Merged
Conversation
…o manifest injection Moves commentMode/checkRunMode/publicSurface (queue.test.ts) and commentMode/checkRunMode/includeMaintainerAuthors/publicAudienceMode/ publicSurface (queue-5.test.ts) off DB-backed upsertRepositorySettings() fixture calls onto upsertRepoFocusManifest() manifest injection (58 + 55 call sites) -- a pure plumbing move with identical resolved test behavior, ahead of these fields moving off repository_settings entirely. Also removes now-redundant LOOPOVER_DRIFT_ISSUE_REPO overrides that #6493 made obsolete, and corrects two stale comments referencing that same removed workaround. Part of #6440, part of #6442
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6533 +/- ##
=======================================
Coverage 95.56% 95.56%
=======================================
Files 589 589
Lines 47121 47121
Branches 14989 14989
=======================================
Hits 45032 45032
Misses 1297 1297
Partials 792 792
Flags with carried forward coverage won't be shown. Click here to find out more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of the Batch A config-as-code migration (#6442, epic #6440): moves the applicable Batch A fields off DB-backed `upsertRepositorySettings()` test fixture calls onto `upsertRepoFocusManifest()` manifest injection in `test/unit/queue.test.ts` (58 call sites) and `test/unit/queue-5.test.ts` (55 call sites). `resolveEffectiveSettings` already overlays manifest settings over DB settings unconditionally, so this is a pure plumbing move -- identical resolved test behavior, verified per-test.
Also removes now-redundant `LOOPOVER_DRIFT_ISSUE_REPO` overrides that #6493's root-cause fix made obsolete, and corrects two stale comments that referenced that same removed workaround.
Scope
Validation