refactor(test): move remaining Batch A fields to manifest injection - #6535
Merged
Conversation
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6535 +/- ##
==========================================
+ Coverage 95.57% 95.81% +0.24%
==========================================
Files 590 589 -1
Lines 47170 47049 -121
Branches 15007 14962 -45
==========================================
- Hits 45081 45079 -2
+ Misses 1297 1176 -121
- Partials 792 794 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
Moves the applicable Batch A fields (commentMode, checkRunMode, checkRunDetailLevel, publicSurface, publicSignalLevel, backfillEnabled, badgeEnabled, publicQualityMetrics) off DB-backed upsertRepositorySettings() fixture calls onto upsertRepoFocusManifest() manifest injection, across the 10 remaining Batch A files (backfill, api, public-quality-metrics-route-error, ci-completion-fork-resume, safety, reputation-wiring, parity-wire, linked-issue-satisfaction-run, repo-profile, actions-fallback-webhook) -- a pure plumbing move with identical resolved test behavior. Deliberately leaves badgeEnabled/ publicQualityMetrics DB-backed in the two tests that specifically exercise loadPublicRepoBadge/loadPublicRepoQualityMetrics, which bypass the manifest overlay entirely for performance on hot public routes. Also removes now-redundant LOOPOVER_DRIFT_ISSUE_REPO overrides that Part of #6440, part of #6442
JSONbored
force-pushed
the
refactor/batch-a-misc-manifest-migration
branch
from
July 16, 2026 12:30
f140d1c to
6c1a081
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of the Batch A config-as-code migration (#6442, epic #6440): moves the applicable Batch A fields off DB-backed `upsertRepositorySettings()` test fixture calls onto `upsertRepoFocusManifest()` manifest injection across the 10 remaining Batch A files (`backfill.test.ts`, `api.test.ts`, `public-quality-metrics-route-error.test.ts`, `ci-completion-fork-resume.test.ts`, `safety.test.ts`, `reputation-wiring.test.ts`, `parity-wire.test.ts`, `linked-issue-satisfaction-run.test.ts`, `repo-profile.test.ts`, `actions-fallback-webhook.test.ts`). `resolveEffectiveSettings` already overlays manifest settings over DB settings unconditionally, so this is a pure plumbing move -- identical resolved test behavior, verified per-test.
Deliberately left DB-backed: `badgeEnabled`/`publicQualityMetrics` in the specific tests exercising `loadPublicRepoBadge`/`loadPublicRepoQualityMetrics` (`src/api/routes.ts`) -- those two routes read `getRepositorySettings` directly and bypass the manifest overlay entirely, a deliberate perf tradeoff for unauthenticated, high-frequency public routes. Moving those two fields to manifest-only would silently change what those specific tests exercise.
Also removes now-redundant `LOOPOVER_DRIFT_ISSUE_REPO` overrides that #6493's root-cause fix made obsolete.
Scope
Validation