fix(miner): grant the claude-cli driver Read/Bash access, not just edits - #6856
Merged
Conversation
--permission-mode acceptEdits only auto-approves file EDIT tool calls -- it never granted Read or Bash, so a real headless attempt (which needs both to explore the repo and run tests before finishing) got every one of those calls denied with no TTY to resolve an interactive prompt, silently producing zero real work on every attempt. Adds --allowedTools Read Bash alongside the existing acceptEdits mode, confirmed via a live end-to-end reproduction (zero denials, a real fix and regression test committed) -- deliberately narrower than --permission-mode bypassPermissions, which would also disable edit confirmation and any other safety rail, not just this specific gap. Closes #6840
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
loopover-ui | 664aebe | Commit Preview URL Branch Preview URL |
Jul 17 2026, 08:48 AM |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6856 +/- ##
=======================================
Coverage 93.64% 93.64%
=======================================
Files 684 684
Lines 68193 68193
Branches 18707 18707
=======================================
Hits 63857 63857
Misses 3350 3350
Partials 986 986
Flags with carried forward coverage won't be shown. Click here to find out more.
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--permission-mode acceptEditsonly auto-approves file EDIT tool calls — it never grantedReadorBash, so a real headless attempt (which needs both to explore the repo and run tests before finishing) got every one of those calls denied with no TTY to resolve an interactive prompt, silently producing zero real work on every attempt.--allowedTools Read Bashalongside the existingacceptEditsmode. Confirmed via a live end-to-end reproduction: zero denials, a real fix + regression test committed by the driver — deliberately narrower than--permission-mode bypassPermissions, which would also disable edit-scope confirmation and any other safety rail, not just this specific gap.Closes #6840
Test plan
npm run test:ci— full local gate green (one unrelated pre-existing flake inai-summaries.test.tsconfirmed via isolated rerun, not caused by this diff)