Skip to content

fix(test): stop rebuilding env/keys per iteration in repo-name validation tests #6880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSONbored merged 1 commit into from
Jul 17, 2026
Merged

fix(test): stop rebuilding env/keys per iteration in repo-name validation tests #6880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions test/unit/github-labels.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,19 @@ describe("GitHub PR labels", () => {
});

it("rejects invalid repository names before making GitHub calls", async () => {
await expect(ensurePullRequestLabel(createTestEnv(), 123, "invalid", 4, "gittensor", { createMissingLabel: true })).rejects.toThrow(/Invalid repository full name/);
await expect(ensurePullRequestLabel(createTestEnv(), 123, "owner/repo/extra", 4, "gittensor", { createMissingLabel: true })).rejects.toThrow(
// Every malformed name below is rejected by parseRepoFullName() (src/github/labels.ts) before
// ensurePullRequestLabel ever touches `env`, so one shared env per env-shape covers every case
// without rebuilding a fresh in-memory SQLite database (166-migration replay, see
// test/helpers/d1.ts) or generating a fresh RSA-2048 key (real synchronous CPU work) on every
// iteration -- that redundant setup, not the code under test, is what timed this test out under
// concurrent full-suite load.
const env = createTestEnv();
await expect(ensurePullRequestLabel(env, 123, "invalid", 4, "gittensor", { createMissingLabel: true })).rejects.toThrow(/Invalid repository full name/);
await expect(ensurePullRequestLabel(env, 123, "owner/repo/extra", 4, "gittensor", { createMissingLabel: true })).rejects.toThrow(
/Invalid repository full name/,
);
for (const padded of [" owner/repo ", "owner/ repo", "owner /repo", "own er/repo"]) {
await expect(ensurePullRequestLabel(createTestEnv(), 123, padded, 4, "gittensor", { createMissingLabel: true })).rejects.toThrow(
await expect(ensurePullRequestLabel(env, 123, padded, 4, "gittensor", { createMissingLabel: true })).rejects.toThrow(
/Invalid repository full name/,
);
}
Expand All @@ -25,10 +32,11 @@ describe("GitHub PR labels", () => {
called = true;
return Response.json({ token: "t" });
});
const keyedEnv = createTestEnv({ GITHUB_APP_PRIVATE_KEY: generateRsaPrivateKeyPem() });
for (const malformed of ["owner/repo/extra", "owner/ repo", "owner /repo"]) {
await expect(
ensurePullRequestLabel(
createTestEnv({ GITHUB_APP_PRIVATE_KEY: generateRsaPrivateKeyPem() }),
keyedEnv,
123,
malformed,
4,
Expand Down
21 changes: 14 additions & 7 deletions test/unit/github-pr-actions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,22 @@ describe("GitHub PR action primitives (#778)", () => {
});

it("validates the repo name before any GitHub call", async () => {
await expect(closePullRequest(createTestEnv(), 1, "invalid", 4)).rejects.toThrow(/Invalid repository full name/);
await expect(closePullRequest(createTestEnv(), 1, "owner/repo/extra", 4)).rejects.toThrow(
// Every malformed name below is rejected by splitRepo() (src/github/pr-actions.ts) before
// closePullRequest ever touches `env`, so one shared env per env-shape covers every case without
// rebuilding a fresh in-memory SQLite database (166-migration replay, see test/helpers/d1.ts) or
// generating a fresh RSA-2048 key (real synchronous CPU work) on every call -- that redundant
// setup, not the code under test, is what timed this test out under concurrent full-suite load.
const env = createTestEnv();
await expect(closePullRequest(env, 1, "invalid", 4)).rejects.toThrow(/Invalid repository full name/);
await expect(closePullRequest(env, 1, "owner/repo/extra", 4)).rejects.toThrow(
/Invalid repository full name/,
);
await expect(closePullRequest(createTestEnv(), 1, " owner/repo ", 4)).rejects.toThrow(
await expect(closePullRequest(env, 1, " owner/repo ", 4)).rejects.toThrow(
/Invalid repository full name/,
);
// Per-segment padding (#6613) — mirrors assignees.ts parseRepoFullName coverage.
for (const padded of ["owner/ repo", "owner /repo"]) {
await expect(closePullRequest(createTestEnv(), 1, padded, 4)).rejects.toThrow(
await expect(closePullRequest(env, 1, padded, 4)).rejects.toThrow(
/Invalid repository full name/,
);
}
Expand All @@ -32,14 +38,15 @@ describe("GitHub PR action primitives (#778)", () => {
called = true;
return Response.json({ token: "t" });
});
await expect(closePullRequest(envWithKey(), 1, "owner/repo/extra", 4)).rejects.toThrow(
const keyedEnv = envWithKey();
await expect(closePullRequest(keyedEnv, 1, "owner/repo/extra", 4)).rejects.toThrow(
/Invalid repository full name/,
);
await expect(closePullRequest(envWithKey(), 1, " owner/repo ", 4)).rejects.toThrow(
await expect(closePullRequest(keyedEnv, 1, " owner/repo ", 4)).rejects.toThrow(
/Invalid repository full name/,
);
for (const padded of ["owner/ repo", "owner /repo"]) {
await expect(closePullRequest(envWithKey(), 1, padded, 4)).rejects.toThrow(
await expect(closePullRequest(keyedEnv, 1, padded, 4)).rejects.toThrow(
/Invalid repository full name/,
);
}
Expand Down
Loading