Skip to content

fix(test): match release-selfhost-prerelease.test.ts to the loopover-orb rename - #6883

Merged
JSONbored merged 1 commit into
mainfrom
worktree-release-selfhost-orb-rename
Jul 17, 2026
Merged

fix(test): match release-selfhost-prerelease.test.ts to the loopover-orb rename#6883
JSONbored merged 1 commit into
mainfrom
worktree-release-selfhost-orb-rename

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Summary

  • Commit 7c5965d8 ("fix(ci): update remaining gittensory references in workflow files") correctly changed .github/workflows/release-selfhost.yml's "Resolve version" step to emit release=loopover-orb@${VERSION} instead of the pre-rename gittensory-orb@${VERSION} -- a real bug fix, not just cosmetic naming (an unset SENTRY_PROJECT was defaulting release builds to the deleted Sentry project's old slug, per that commit's own detailed message).
  • test/unit/release-selfhost-prerelease.test.ts executes that exact bash step (extracted straight out of the committed workflow YAML, not a re-derived copy) and asserts on its real output -- it wasn't updated to match, so it started failing deterministically: expected "gittensory-orb@0.1.0", received "loopover-orb@0.1.0".
  • Discovered while running the full local gate for an unrelated PR (fix(test): stop rebuilding env/keys per iteration in repo-name validation tests #6880). Confirmed this is the only stale reference in this specific file (grep -n "gittensory-orb" test/unit/release-selfhost-prerelease.test.ts -- one hit) and confirmed via git show 7c5965d8 that the production-side change was intentional and correct, not itself a bug to revert.

Scope

  • The PR title follows type(scope): short summary Conventional Commit format.
  • This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
  • This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
  • I linked a currently open issue this PR resolves -- not applicable; this is a maintainer-authored test-reliability fix, not a contributor PR under the linked-issue policy.

Validation

  • git diff --check
  • npm run actionlint
  • npm run typecheck
  • npm run test:coverage locally -- test-only change to test/**, which Codecov does not measure, so there is no patch-coverage obligation.
  • npm run test:workers
  • npm run build:mcp
  • npm run test:mcp-pack
  • npm run ui:openapi:check
  • npm run ui:lint
  • npm run ui:typecheck
  • npm run ui:build
  • npm audit --audit-level=moderate
  • New or changed behavior has unit/integration tests for new branches, fallback paths, and sanitizer boundaries -- not applicable; no production code changed, this is a one-line expected-value correction.

Additional validation: a full local npm run test:ci run is fully green with this change (all steps, zero failures).

Safety

  • No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
  • Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics. (Not applicable -- test-only change.)
  • Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests. (Not applicable -- no such changes.)
  • API/OpenAPI/MCP behavior is updated and tested where needed. (Not applicable -- no such changes.)
  • UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks. (Not applicable -- no UI changes.)
  • Visible UI changes include a UI Evidence section below. (Not applicable -- no visible/UI changes.)
  • Public docs/changelogs are updated where needed. (Not applicable.)

UI Evidence

Not applicable -- test-only change, no UI/frontend/docs surface touched.

Notes

  • A broader, related cleanup (other stale gittensory/gittensory-orb bot-identity references across ~15 test files, including test/helpers/d1.ts's createTestEnv() default) is being investigated and will follow in a separate PR.

…orb rename

Commit 7c5965d (fix(ci): update remaining gittensory references in workflow
files) correctly changed .github/workflows/release-selfhost.yml's "Resolve
version" step to emit release=loopover-orb@${VERSION} instead of the pre-rename
gittensory-orb@${VERSION} (a real bug, not just stale naming -- an unset
SENTRY_PROJECT was defaulting release builds to the deleted Sentry project's old
slug). The test that executes that exact bash step and asserts on its output
wasn't updated to match, so it started failing deterministically: expected
"gittensory-orb@0.1.0", received "loopover-orb@0.1.0".
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@JSONbored JSONbored self-assigned this Jul 17, 2026
@JSONbored
JSONbored merged commit ac0a775 into main Jul 17, 2026
12 checks passed
@JSONbored
JSONbored deleted the worktree-release-selfhost-orb-rename branch July 17, 2026 10:18
@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 17, 2026
@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.70%. Comparing base (80869bd) to head (a2ec955).
⚠️ Report is 13 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6883       +/-   ##
===========================================
+ Coverage   70.98%   93.70%   +22.71%     
===========================================
  Files         685      685               
  Lines       68262    68262               
  Branches    18711    18711               
===========================================
+ Hits        48457    63963    +15506     
+ Misses      16006     3302    -12704     
+ Partials     3799      997     -2802     
Flag Coverage Δ
shard-1 43.22% <ø> (-0.41%) ⬇️
shard-2 36.93% <ø> (?)
shard-3 32.62% <ø> (?)
shard-4 34.36% <ø> (?)
shard-5 31.47% <ø> (?)
shard-6 45.97% <ø> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 387 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant