fix(test): match release-selfhost-prerelease.test.ts to the loopover-orb rename - #6883
Merged
Merged
Conversation
…orb rename Commit 7c5965d (fix(ci): update remaining gittensory references in workflow files) correctly changed .github/workflows/release-selfhost.yml's "Resolve version" step to emit release=loopover-orb@${VERSION} instead of the pre-rename gittensory-orb@${VERSION} (a real bug, not just stale naming -- an unset SENTRY_PROJECT was defaulting release builds to the deleted Sentry project's old slug). The test that executes that exact bash step and asserts on its output wasn't updated to match, so it started failing deterministically: expected "gittensory-orb@0.1.0", received "loopover-orb@0.1.0".
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6883 +/- ##
===========================================
+ Coverage 70.98% 93.70% +22.71%
===========================================
Files 685 685
Lines 68262 68262
Branches 18711 18711
===========================================
+ Hits 48457 63963 +15506
+ Misses 16006 3302 -12704
+ Partials 3799 997 -2802
Flags with carried forward coverage won't be shown. Click here to find out more. |
24 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
7c5965d8("fix(ci): update remaining gittensory references in workflow files") correctly changed.github/workflows/release-selfhost.yml's "Resolve version" step to emitrelease=loopover-orb@${VERSION}instead of the pre-renamegittensory-orb@${VERSION}-- a real bug fix, not just cosmetic naming (an unsetSENTRY_PROJECTwas defaulting release builds to the deleted Sentry project's old slug, per that commit's own detailed message).test/unit/release-selfhost-prerelease.test.tsexecutes that exact bash step (extracted straight out of the committed workflow YAML, not a re-derived copy) and asserts on its real output -- it wasn't updated to match, so it started failing deterministically: expected"gittensory-orb@0.1.0", received"loopover-orb@0.1.0".grep -n "gittensory-orb" test/unit/release-selfhost-prerelease.test.ts-- one hit) and confirmed viagit show 7c5965d8that the production-side change was intentional and correct, not itself a bug to revert.Scope
type(scope): short summaryConventional Commit format.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragelocally -- test-only change totest/**, which Codecov does not measure, so there is no patch-coverage obligation.npm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderateAdditional validation: a full local
npm run test:cirun is fully green with this change (all steps, zero failures).Safety
UI Evidencesection below. (Not applicable -- no visible/UI changes.)UI Evidence
Not applicable -- test-only change, no UI/frontend/docs surface touched.
Notes
gittensory/gittensory-orbbot-identity references across ~15 test files, includingtest/helpers/d1.ts'screateTestEnv()default) is being investigated and will follow in a separate PR.